public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Gautham R Shenoy <ego@in.ibm.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, ego@in.ibm.com, hpa@zytor.com,
	mingo@redhat.com, tony.luck@intel.com, tglx@linutronix.de,
	mingo@elte.hu
Subject: [tip:sched/urgent] sched: Avoid printing sched_group::__cpu_power for default case
Date: Tue, 14 Apr 2009 18:42:33 GMT	[thread overview]
Message-ID: <tip-728fc565bdfc98dc7086fdcccb3f1e1edf195b20@git.kernel.org> (raw)
In-Reply-To: <20090414033936.GA534@in.ibm.com>

Commit-ID:  728fc565bdfc98dc7086fdcccb3f1e1edf195b20
Gitweb:     http://git.kernel.org/tip/728fc565bdfc98dc7086fdcccb3f1e1edf195b20
Author:     Gautham R Shenoy <ego@in.ibm.com>
AuthorDate: Tue, 14 Apr 2009 09:09:36 +0530
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 14 Apr 2009 20:39:40 +0200

sched: Avoid printing sched_group::__cpu_power for default case

Impact: reduce syslog clutter

Commit 46e0bb9c12f4 ("sched: Print sched_group::__cpu_power
in sched_domain_debug") produces a messy dmesg output while
attempting to print the sched_group::__cpu_power for each
group in the sched_domain hierarchy.

Fix this by avoid printing the __cpu_power for default cases.
(i.e, __cpu_power == SCHED_LOAD_SCALE).

Reported-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Gautham R Shenoy <ego@in.ibm.com>
Fixed-by: Tony Luck <tony.luck@intel.com>
Cc: a.p.zijlstra@chello.nl
LKML-Reference: <20090414033936.GA534@in.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 kernel/sched.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index e90e70e..b902e58 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -7367,8 +7367,12 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,
 		cpumask_or(groupmask, groupmask, sched_group_cpus(group));
 
 		cpulist_scnprintf(str, sizeof(str), sched_group_cpus(group));
-		printk(KERN_CONT " %s (__cpu_power = %d)", str,
-						group->__cpu_power);
+
+		printk(KERN_CONT " %s", str);
+		if (group->__cpu_power != SCHED_LOAD_SCALE) {
+			printk(KERN_CONT " (__cpu_power = %d)",
+				group->__cpu_power);
+		}
 
 		group = group->next;
 	} while (group != sd->groups);

  parent reply	other threads:[~2009-04-14 18:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-30  4:55 [PATCH] sched: Print sched_group::__cpu_power in sched_domain_debug Gautham R Shenoy
2009-03-30  4:55 ` Gautham R Shenoy
2009-04-01 16:03   ` [tip:sched/urgent] " Gautham R Shenoy
2009-04-13 18:53     ` Tony Luck
2009-04-14  0:09       ` Ingo Molnar
2009-04-14  3:39         ` Gautham R Shenoy
2009-04-14 12:03           ` [tip:sched/urgent] sched: Avoid printing sched_group::__cpu_power for default case tip-bot for Gautham R Shenoy
2009-04-14 16:29           ` [tip:sched/urgent] sched: Print sched_group::__cpu_power in sched_domain_debug Luck, Tony
2009-04-14 17:06             ` Gautham R Shenoy
2009-04-14 17:18               ` Luck, Tony
2009-04-14 18:40                 ` Ingo Molnar
2009-04-14 18:42           ` tip-bot for Gautham R Shenoy [this message]
2009-04-16 22:48           ` [tip:sched/urgent] sched: Avoid printing sched_group::__cpu_power for default case tip-bot for Gautham R Shenoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-728fc565bdfc98dc7086fdcccb3f1e1edf195b20@git.kernel.org \
    --to=ego@in.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox