From: Markus Metzger <markus.t.metzger@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
eranian@googlemail.com, markus.t.metzger@intel.com,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/urgent] x86, pebs: correct qualifier passed to ds_write_config() from ds_request_pebs()
Date: Fri, 6 Mar 2009 15:15:36 GMT [thread overview]
Message-ID: <tip-73bf1b62f561fc8ecb00e2810efe4fe769f4933e@git.kernel.org> (raw)
In-Reply-To: <20090305085721.A22550@sedona.ch.intel.com>
Commit-ID: 73bf1b62f561fc8ecb00e2810efe4fe769f4933e
Gitweb: http://git.kernel.org/tip/73bf1b62f561fc8ecb00e2810efe4fe769f4933e
Author: "Markus Metzger" <markus.t.metzger@intel.com>
AuthorDate: Thu, 5 Mar 2009 08:57:21 +0100
Commit: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 6 Mar 2009 16:13:15 +0100
x86, pebs: correct qualifier passed to ds_write_config() from ds_request_pebs()
ds_write_config() can write the BTS as well as the PEBS part of
the DS config. ds_request_pebs() passes the wrong qualifier, which
results in the wrong configuration to be written.
Reported-by: Stephane Eranian <eranian@googlemail.com>
Signed-off-by: Markus Metzger <markus.t.metzger@intel.com>
LKML-Reference: <20090305085721.A22550@sedona.ch.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/ds.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/ds.c b/arch/x86/kernel/ds.c
index de7cdbd..87b67e3 100644
--- a/arch/x86/kernel/ds.c
+++ b/arch/x86/kernel/ds.c
@@ -729,7 +729,7 @@ struct pebs_tracer *ds_request_pebs(struct task_struct *task,
spin_unlock_irqrestore(&ds_lock, irq);
- ds_write_config(tracer->ds.context, &tracer->trace.ds, ds_bts);
+ ds_write_config(tracer->ds.context, &tracer->trace.ds, ds_pebs);
ds_resume_pebs(tracer);
return tracer;
prev parent reply other threads:[~2009-03-06 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 7:57 [patch] x86, pebs: correct qualifier passed to ds_write_config() from ds_request_pebs() Markus Metzger
2009-03-06 15:15 ` Markus Metzger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-73bf1b62f561fc8ecb00e2810efe4fe769f4933e@git.kernel.org \
--to=markus.t.metzger@intel.com \
--cc=eranian@googlemail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox