public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] x86, pebs: correct qualifier passed to ds_write_config() from ds_request_pebs()
@ 2009-03-05  7:57 Markus Metzger
  2009-03-06 15:15 ` [tip:x86/urgent] " Markus Metzger
  0 siblings, 1 reply; 2+ messages in thread
From: Markus Metzger @ 2009-03-05  7:57 UTC (permalink / raw)
  To: linux-kernel, mingo, tglx, hpa
  Cc: markus.t.metzger, markus.t.metzger, roland, oleg, juan.villacis,
	ak

ds_write_config() can write the BTS as well as the PEBS part of the DS config.
ds_request_pebs() passes the wrong qualifier, which results in the
wrong configuration to be written.

Reported-by: Stephane Eranian <eranian@googlemail.com>
Signed-off-by: Markus Metzger <markus.t.metzger@intel.com>
---

Index: gits/arch/x86/kernel/ds.c
===================================================================
--- gits.orig/arch/x86/kernel/ds.c	2009-03-04 14:41:15.000000000 +0100
+++ gits/arch/x86/kernel/ds.c	2009-03-04 14:49:01.000000000 +0100
@@ -729,7 +729,7 @@ struct pebs_tracer *ds_request_pebs(stru
 
 	spin_unlock_irqrestore(&ds_lock, irq);
 
-	ds_write_config(tracer->ds.context, &tracer->trace.ds, ds_bts);
+	ds_write_config(tracer->ds.context, &tracer->trace.ds, ds_pebs);
 	ds_resume_pebs(tracer);
 
 	return tracer;
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-06 15:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-05  7:57 [patch] x86, pebs: correct qualifier passed to ds_write_config() from ds_request_pebs() Markus Metzger
2009-03-06 15:15 ` [tip:x86/urgent] " Markus Metzger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox