linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, paulus@samba.org,
	hpa@zytor.com, mingo@kernel.org, a.p.zijlstra@chello.nl,
	namhyung.kim@lge.com, namhyung@kernel.org, dsahern@gmail.com,
	tglx@linutronix.de
Subject: [tip:perf/urgent] perf trace: Beautify fifth argument of mmap() as fd
Date: Tue, 12 Nov 2013 13:56:04 -0800	[thread overview]
Message-ID: <tip-73faab3a421351c342b10b0177fec9eea1a1d809@git.kernel.org> (raw)
In-Reply-To: <1384237500-22991-1-git-send-email-namhyung@kernel.org>

Commit-ID:  73faab3a421351c342b10b0177fec9eea1a1d809
Gitweb:     http://git.kernel.org/tip/73faab3a421351c342b10b0177fec9eea1a1d809
Author:     Namhyung Kim <namhyung.kim@lge.com>
AuthorDate: Tue, 12 Nov 2013 15:24:59 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 12 Nov 2013 13:00:23 -0300

perf trace: Beautify fifth argument of mmap() as fd

The fifth argument of mmap syscall is fd and it often contains -1 as a
value for anon mappings.  Without this patch it doesn't show the file
name as well as it shows -1 as 4294967295.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1384237500-22991-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-trace.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index c3008b1..aeb6296 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -951,7 +951,8 @@ static struct syscall_fmt {
 	{ .name	    = "mmap",	    .hexret = true,
 	  .arg_scnprintf = { [0] = SCA_HEX,	  /* addr */
 			     [2] = SCA_MMAP_PROT, /* prot */
-			     [3] = SCA_MMAP_FLAGS, /* flags */ }, },
+			     [3] = SCA_MMAP_FLAGS, /* flags */
+			     [4] = SCA_FD, 	  /* fd */ }, },
 	{ .name	    = "mprotect",   .errmsg = true,
 	  .arg_scnprintf = { [0] = SCA_HEX, /* start */
 			     [2] = SCA_MMAP_PROT, /* prot */ }, },

      parent reply	other threads:[~2013-11-12 21:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12  6:24 [PATCH 1/2] perf trace: Beautify fifth argument of mmap() as fd Namhyung Kim
2013-11-12  6:25 ` [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data Namhyung Kim
2013-11-12 11:46   ` Arnaldo Carvalho de Melo
2013-11-12 11:57     ` Arnaldo Carvalho de Melo
2013-11-12 12:15       ` Arnaldo Carvalho de Melo
2013-11-12 21:31         ` Namhyung Kim
2013-11-12 21:27       ` Namhyung Kim
2013-11-12 13:23         ` Arnaldo Carvalho de Melo
2013-11-12 21:56       ` [tip:perf/urgent] perf trace: Separate tp syscall field caching into init routine to be reused tip-bot for Namhyung Kim
2013-11-12 21:56   ` [tip:perf/urgent] perf trace: Fix segfault on perf trace -i perf.data tip-bot for Namhyung Kim
2013-11-12 15:50 ` [PATCH 1/2] perf trace: Beautify fifth argument of mmap() as fd David Ahern
2013-11-12 21:56 ` tip-bot for Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-73faab3a421351c342b10b0177fec9eea1a1d809@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).