public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Alexander Shishkin <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: peterz@infradead.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, mingo@kernel.org,
	torvalds@linux-foundation.org, hpa@zytor.com,
	alexander.shishkin@linux.intel.com, paulus@samba.org
Subject: [tip:perf/core] perf/x86/intel/pt: Kill an unused variable
Date: Wed, 27 May 2015 03:07:43 -0700	[thread overview]
Message-ID: <tip-74387bcb711b7b2ed65c0ed08953e13d4e31969e@git.kernel.org> (raw)
In-Reply-To: <1429622177-22843-2-git-send-email-alexander.shishkin@linux.intel.com>

Commit-ID:  74387bcb711b7b2ed65c0ed08953e13d4e31969e
Gitweb:     http://git.kernel.org/tip/74387bcb711b7b2ed65c0ed08953e13d4e31969e
Author:     Alexander Shishkin <alexander.shishkin@linux.intel.com>
AuthorDate: Tue, 21 Apr 2015 16:16:13 +0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 27 May 2015 09:17:46 +0200

perf/x86/intel/pt: Kill an unused variable

Currently, there's a set-but-not-used variable in setup_topa_index();
this patch gets rid of it. And while at it, fixes a style issue with
brackets around a one-line block.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: acme@infradead.org
Cc: adrian.hunter@intel.com
Cc: hpa@zytor.com
Link: http://lkml.kernel.org/r/1429622177-22843-2-git-send-email-alexander.shishkin@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/cpu/perf_event_intel_pt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/perf_event_intel_pt.c b/arch/x86/kernel/cpu/perf_event_intel_pt.c
index 5b804f9..8a45956 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_pt.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_pt.c
@@ -674,7 +674,7 @@ static void pt_buffer_setup_topa_index(struct pt_buffer *buf)
 	struct topa *cur = buf->first, *prev = buf->last;
 	struct topa_entry *te_cur = TOPA_ENTRY(cur, 0),
 		*te_prev = TOPA_ENTRY(prev, prev->last - 1);
-	int pg = 0, idx = 0, ntopa = 0;
+	int pg = 0, idx = 0;
 
 	while (pg < buf->nr_pages) {
 		int tidx;
@@ -689,9 +689,9 @@ static void pt_buffer_setup_topa_index(struct pt_buffer *buf)
 			/* advance to next topa table */
 			idx = 0;
 			cur = list_entry(cur->list.next, struct topa, list);
-			ntopa++;
-		} else
+		} else {
 			idx++;
+		}
 		te_cur = TOPA_ENTRY(cur, idx);
 	}
 

  reply	other threads:[~2015-05-27 10:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 13:16 [PATCH 0/5] perf/x86/intel/pt: Driver fixes and cleanups Alexander Shishkin
2015-04-21 13:16 ` [PATCH 1/5] perf/x86/intel/pt: Kill an unused variable Alexander Shishkin
2015-05-27 10:07   ` tip-bot for Alexander Shishkin [this message]
2015-04-21 13:16 ` [PATCH 2/5] perf/x86/intel/pt: Untangle pt_buffer_reset_markers() Alexander Shishkin
2015-04-21 13:16 ` [PATCH 3/5] perf/x86/intel/pt: Document pt_buffer_reset_markers() Alexander Shishkin
2015-05-27 10:07   ` [tip:perf/core] " tip-bot for Alexander Shishkin
2015-04-21 13:16 ` [PATCH 4/5] perf/x86/intel/pt: Document pt_buffer_reset_offsets() Alexander Shishkin
2015-05-27 10:08   ` [tip:perf/core] " tip-bot for Alexander Shishkin
2015-04-21 13:16 ` [PATCH 5/5] perf/x86/intel/pt: Kill pt_is_running() Alexander Shishkin
2015-05-27 10:08   ` [tip:perf/core] " tip-bot for Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-74387bcb711b7b2ed65c0ed08953e13d4e31969e@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox