From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759901AbcBYFwS (ORCPT ); Thu, 25 Feb 2016 00:52:18 -0500 Received: from torg.zytor.com ([198.137.202.12]:54150 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759850AbcBYFwM (ORCPT ); Thu, 25 Feb 2016 00:52:12 -0500 Date: Wed, 24 Feb 2016 21:49:52 -0800 From: tip-bot for Josh Poimboeuf Message-ID: Cc: acme@kernel.org, torvalds@linux-foundation.org, brgerst@gmail.com, mingo@kernel.org, palves@redhat.com, matt@codeblueprint.co.uk, namhyung@gmail.com, akpm@linux-foundation.org, luto@amacapital.net, luto@kernel.org, peterz@infradead.org, chris.j.arges@canonical.com, mmarek@suse.cz, hpa@zytor.com, dvlasenk@redhat.com, bp@suse.de, bernd@petrovitsch.priv.at, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, jslaby@suse.cz, tglx@linutronix.de, bp@alien8.de Reply-To: peterz@infradead.org, chris.j.arges@canonical.com, mmarek@suse.cz, akpm@linux-foundation.org, luto@kernel.org, luto@amacapital.net, bp@alien8.de, linux-kernel@vger.kernel.org, tglx@linutronix.de, jslaby@suse.cz, jpoimboe@redhat.com, hpa@zytor.com, bernd@petrovitsch.priv.at, dvlasenk@redhat.com, bp@suse.de, torvalds@linux-foundation.org, brgerst@gmail.com, acme@kernel.org, namhyung@gmail.com, matt@codeblueprint.co.uk, palves@redhat.com, mingo@kernel.org In-Reply-To: <2294b6fad60eea4cc862eddc8e98a1324e6eeeca.1453405861.git.jpoimboe@redhat.com> References: <2294b6fad60eea4cc862eddc8e98a1324e6eeeca.1453405861.git.jpoimboe@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/debug] x86/asm/efi: Create a stack frame in efi_call() Git-Commit-ID: 779c433b8ea5c9fdfb892265b2ca6213d1f12ff8 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 779c433b8ea5c9fdfb892265b2ca6213d1f12ff8 Gitweb: http://git.kernel.org/tip/779c433b8ea5c9fdfb892265b2ca6213d1f12ff8 Author: Josh Poimboeuf AuthorDate: Thu, 21 Jan 2016 16:49:23 -0600 Committer: Ingo Molnar CommitDate: Wed, 24 Feb 2016 08:35:43 +0100 x86/asm/efi: Create a stack frame in efi_call() efi_call() is a callable non-leaf function which doesn't honor CONFIG_FRAME_POINTER, which can result in bad stack traces. Create a stack frame for it when CONFIG_FRAME_POINTER is enabled. Signed-off-by: Josh Poimboeuf Reviewed-by: Matt Fleming Reviewed-by: Borislav Petkov Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Chris J Arges Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Jiri Slaby Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/2294b6fad60eea4cc862eddc8e98a1324e6eeeca.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/platform/efi/efi_stub_64.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/platform/efi/efi_stub_64.S b/arch/x86/platform/efi/efi_stub_64.S index 86d0f9e..0df2dcc 100644 --- a/arch/x86/platform/efi/efi_stub_64.S +++ b/arch/x86/platform/efi/efi_stub_64.S @@ -11,6 +11,7 @@ #include #include #include +#include #define SAVE_XMM \ mov %rsp, %rax; \ @@ -74,6 +75,7 @@ .endm ENTRY(efi_call) + FRAME_BEGIN SAVE_XMM mov (%rsp), %rax mov 8(%rax), %rax @@ -88,6 +90,7 @@ ENTRY(efi_call) RESTORE_PGT addq $48, %rsp RESTORE_XMM + FRAME_END ret ENDPROC(efi_call)