linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix segfault in perf probe
@ 2013-03-12  9:02 Ananth N Mavinakayanahalli
  2013-03-12  9:46 ` Srikar Dronamraju
  2013-03-18 10:56 ` [tip:perf/urgent] perf probe: Fix segfault tip-bot for Ananth N Mavinakayanahalli
  0 siblings, 2 replies; 3+ messages in thread
From: Ananth N Mavinakayanahalli @ 2013-03-12  9:02 UTC (permalink / raw)
  To: acme; +Cc: lkml, Srikar Dronamraju

From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>

Fix segfault in perf probe due to a bug introduced by commit d8639f068
(perf tools: Stop using 'self' in strlist).


Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>

---
Index: linus/tools/perf/util/strlist.c
===================================================================
--- linus.orig/tools/perf/util/strlist.c
+++ linus/tools/perf/util/strlist.c
@@ -143,7 +143,7 @@ struct strlist *strlist__new(bool dupstr
 		slist->rblist.node_delete = strlist__node_delete;
 
 		slist->dupstr	 = dupstr;
-		if (slist && strlist__parse_list(slist, list) != 0)
+		if (list && strlist__parse_list(slist, list) != 0)
 			goto out_error;
 	}
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix segfault in perf probe
  2013-03-12  9:02 [PATCH] Fix segfault in perf probe Ananth N Mavinakayanahalli
@ 2013-03-12  9:46 ` Srikar Dronamraju
  2013-03-18 10:56 ` [tip:perf/urgent] perf probe: Fix segfault tip-bot for Ananth N Mavinakayanahalli
  1 sibling, 0 replies; 3+ messages in thread
From: Srikar Dronamraju @ 2013-03-12  9:46 UTC (permalink / raw)
  To: Ananth N Mavinakayanahalli; +Cc: acme, lkml

* Ananth N Mavinakayanahalli <ananth@in.ibm.com> [2013-03-12 14:32:17]:

> From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> 
> Fix segfault in perf probe due to a bug introduced by commit d8639f068
> (perf tools: Stop using 'self' in strlist).
> 
> 
> Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>

Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

> 
> ---
> Index: linus/tools/perf/util/strlist.c
> ===================================================================
> --- linus.orig/tools/perf/util/strlist.c
> +++ linus/tools/perf/util/strlist.c
> @@ -143,7 +143,7 @@ struct strlist *strlist__new(bool dupstr
>  		slist->rblist.node_delete = strlist__node_delete;
> 
>  		slist->dupstr	 = dupstr;
> -		if (slist && strlist__parse_list(slist, list) != 0)
> +		if (list && strlist__parse_list(slist, list) != 0)
>  			goto out_error;
>  	}
> 

-- 
Thanks and Regards
Srikar Dronamraju


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:perf/urgent] perf probe: Fix segfault
  2013-03-12  9:02 [PATCH] Fix segfault in perf probe Ananth N Mavinakayanahalli
  2013-03-12  9:46 ` Srikar Dronamraju
@ 2013-03-18 10:56 ` tip-bot for Ananth N Mavinakayanahalli
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Ananth N Mavinakayanahalli @ 2013-03-18 10:56 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: acme, linux-kernel, ananth, hpa, mingo, srikar, tglx

Commit-ID:  79146a69c8bc3f28e51c5267633abc6babf47a31
Gitweb:     http://git.kernel.org/tip/79146a69c8bc3f28e51c5267633abc6babf47a31
Author:     Ananth N Mavinakayanahalli <ananth@in.ibm.com>
AuthorDate: Tue, 12 Mar 2013 14:32:17 +0530
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 13 Mar 2013 17:00:33 -0300

perf probe: Fix segfault

Fix segfault in perf probe due to a bug introduced by commit d8639f068
(perf tools: Stop using 'self' in strlist).

Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20130312090217.GC4668@in.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/strlist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/strlist.c b/tools/perf/util/strlist.c
index 55433aa..eabdce0 100644
--- a/tools/perf/util/strlist.c
+++ b/tools/perf/util/strlist.c
@@ -143,7 +143,7 @@ struct strlist *strlist__new(bool dupstr, const char *list)
 		slist->rblist.node_delete = strlist__node_delete;
 
 		slist->dupstr	 = dupstr;
-		if (slist && strlist__parse_list(slist, list) != 0)
+		if (list && strlist__parse_list(slist, list) != 0)
 			goto out_error;
 	}
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-03-18 10:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-12  9:02 [PATCH] Fix segfault in perf probe Ananth N Mavinakayanahalli
2013-03-12  9:46 ` Srikar Dronamraju
2013-03-18 10:56 ` [tip:perf/urgent] perf probe: Fix segfault tip-bot for Ananth N Mavinakayanahalli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).