public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Brian Gerst <brgerst@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	torvalds@linux-foundation.org, arjan@linux.intel.com,
	brgerst@gmail.com, penberg@kernel.org, tglx@linutronix.de,
	linux@merz-ka.de, mingo@elte.hu
Subject: [tip:x86/urgent] x86: Clear irqstack thread_info
Date: Tue, 18 Jan 2011 19:03:53 GMT	[thread overview]
Message-ID: <tip-7b698ea377e10b074ceef0d79218e6622d618421@git.kernel.org> (raw)
In-Reply-To: <AANLkTimyKXfJ1x8tgwrr1hYnNLrPfgE1NTe4z7L6tUDm@mail.gmail.com>

Commit-ID:  7b698ea377e10b074ceef0d79218e6622d618421
Gitweb:     http://git.kernel.org/tip/7b698ea377e10b074ceef0d79218e6622d618421
Author:     Brian Gerst <brgerst@gmail.com>
AuthorDate: Mon, 17 Jan 2011 07:32:10 -0500
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 18 Jan 2011 14:58:37 +0100

x86: Clear irqstack thread_info

Mathias Merz reported that v2.6.37 failed to boot on his
system.

Make sure that the thread_info part of the irqstack is
initialized to zeroes.

Reported-and-Tested-by: Matthias Merz <linux@merz-ka.de>
Signed-off-by: Brian Gerst <brgerst@gmail.com>
Acked-by: Pekka Enberg <penberg@kernel.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
LKML-Reference: <AANLkTimyKXfJ1x8tgwrr1hYnNLrPfgE1NTe4z7L6tUDm@mail.gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/irq_32.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/irq_32.c b/arch/x86/kernel/irq_32.c
index 96656f2..5206bb9 100644
--- a/arch/x86/kernel/irq_32.c
+++ b/arch/x86/kernel/irq_32.c
@@ -129,8 +129,7 @@ void __cpuinit irq_ctx_init(int cpu)
 	irqctx = page_address(alloc_pages_node(cpu_to_node(cpu),
 					       THREAD_FLAGS,
 					       THREAD_ORDER));
-	irqctx->tinfo.task		= NULL;
-	irqctx->tinfo.exec_domain	= NULL;
+	memset(&irqctx->tinfo, 0, sizeof(struct thread_info));
 	irqctx->tinfo.cpu		= cpu;
 	irqctx->tinfo.preempt_count	= HARDIRQ_OFFSET;
 	irqctx->tinfo.addr_limit	= MAKE_MM_SEG(0);
@@ -140,10 +139,8 @@ void __cpuinit irq_ctx_init(int cpu)
 	irqctx = page_address(alloc_pages_node(cpu_to_node(cpu),
 					       THREAD_FLAGS,
 					       THREAD_ORDER));
-	irqctx->tinfo.task		= NULL;
-	irqctx->tinfo.exec_domain	= NULL;
+	memset(&irqctx->tinfo, 0, sizeof(struct thread_info));
 	irqctx->tinfo.cpu		= cpu;
-	irqctx->tinfo.preempt_count	= 0;
 	irqctx->tinfo.addr_limit	= MAKE_MM_SEG(0);
 
 	per_cpu(softirq_ctx, cpu) = irqctx;

  parent reply	other threads:[~2011-01-18 19:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110110223154.GA9739@merz.inka.de>
2011-01-11  7:50 ` Regression in linux 2.6.37: failure to boot, caused by commit 37d57443d5 (mm/slub.c) Pekka Enberg
2011-01-11 13:09   ` Regression in linux 2.6.37: failure on remount / (ext4) rw (was: Re: Regression in linux 2.6.37: failure to boot, caused by commit 37d57443d5 (mm/slub.c)) Matthias Merz
2011-01-12  7:03     ` Pekka Enberg
2011-01-14 14:04       ` Regression in linux 2.6.37: failure on remount / (ext4) rw Matthias Merz
2011-01-17 12:32         ` Brian Gerst
2011-01-18 13:47           ` Matthias Merz
2011-01-18 13:49           ` Pekka Enberg
2011-01-18 19:03           ` tip-bot for Brian Gerst [this message]
2011-01-18 21:45             ` [tip:x86/urgent] x86: Clear irqstack thread_info Pekka Enberg
2011-01-18 22:09               ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-7b698ea377e10b074ceef0d79218e6622d618421@git.kernel.org \
    --to=brgerst@gmail.com \
    --cc=arjan@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=linux@merz-ka.de \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=penberg@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox