From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758626AbbJINI6 (ORCPT ); Fri, 9 Oct 2015 09:08:58 -0400 Received: from terminus.zytor.com ([198.137.202.10]:45871 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758599AbbJINI4 (ORCPT ); Fri, 9 Oct 2015 09:08:56 -0400 Date: Fri, 9 Oct 2015 06:08:00 -0700 From: tip-bot for Andy Lutomirski Message-ID: Cc: torvalds@linux-foundation.org, mingo@kernel.org, luto@amacapital.net, bp@alien8.de, brgerst@gmail.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, dvlasenk@redhat.com, hpa@zytor.com, peterz@infradead.org, luto@kernel.org Reply-To: peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, brgerst@gmail.com, bp@alien8.de, linux-kernel@vger.kernel.org, hpa@zytor.com, dvlasenk@redhat.com, luto@amacapital.net, mingo@kernel.org, torvalds@linux-foundation.org In-Reply-To: <65a38a9edee61a1158cfd230800c61dbd963dac5.1444091584.git.luto@kernel.org> References: <65a38a9edee61a1158cfd230800c61dbd963dac5.1444091584.git.luto@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/asm] x86/elf/64: Clear more registers in elf_common_init () Git-Commit-ID: 7bcdea4d050cbe4912854a68b93494203eec8b24 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 7bcdea4d050cbe4912854a68b93494203eec8b24 Gitweb: http://git.kernel.org/tip/7bcdea4d050cbe4912854a68b93494203eec8b24 Author: Andy Lutomirski AuthorDate: Mon, 5 Oct 2015 17:48:00 -0700 Committer: Ingo Molnar CommitDate: Fri, 9 Oct 2015 09:41:06 +0200 x86/elf/64: Clear more registers in elf_common_init() Before we start calling execve in contexts that honor the full pt_regs, we need to teach it to initialize all registers. Signed-off-by: Andy Lutomirski Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-kernel@vger.kernel.org Link: http://lkml.kernel.org/r/65a38a9edee61a1158cfd230800c61dbd963dac5.1444091584.git.luto@kernel.org Signed-off-by: Ingo Molnar --- arch/x86/include/asm/elf.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h index 2ee05c4..1514753 100644 --- a/arch/x86/include/asm/elf.h +++ b/arch/x86/include/asm/elf.h @@ -171,11 +171,11 @@ do { \ static inline void elf_common_init(struct thread_struct *t, struct pt_regs *regs, const u16 ds) { - /* Commented-out registers are cleared in stub_execve */ - /*regs->ax = regs->bx =*/ regs->cx = regs->dx = 0; - regs->si = regs->di /*= regs->bp*/ = 0; + /* ax gets execve's return value. */ + /*regs->ax = */ regs->bx = regs->cx = regs->dx = 0; + regs->si = regs->di = regs->bp = 0; regs->r8 = regs->r9 = regs->r10 = regs->r11 = 0; - /*regs->r12 = regs->r13 = regs->r14 = regs->r15 = 0;*/ + regs->r12 = regs->r13 = regs->r14 = regs->r15 = 0; t->fs = t->gs = 0; t->fsindex = t->gsindex = 0; t->ds = t->es = ds;