public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "tip-bot for Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
	hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de,
	laijs@cn.fujitsu.com, mingo@elte.hu
Subject: [tip:core/rcu] rcu: Add "notrace" to RCU function headers used by ftrace
Date: Tue, 25 Aug 2009 07:13:02 GMT	[thread overview]
Message-ID: <tip-7c614d6461399acca5c0ba444f5db49cb332fc08@git.kernel.org> (raw)
In-Reply-To: <12511321213243-git-send-email->

Commit-ID:  7c614d6461399acca5c0ba444f5db49cb332fc08
Gitweb:     http://git.kernel.org/tip/7c614d6461399acca5c0ba444f5db49cb332fc08
Author:     Paul E. McKenney <paulmck@linux.vnet.ibm.com>
AuthorDate: Mon, 24 Aug 2009 09:42:00 -0700
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 24 Aug 2009 20:37:04 +0200

rcu: Add "notrace" to RCU function headers used by ftrace

Both rcu_read_lock_sched_notrace() and
rcu_read_unlock_sched_notrace() are used by ftrace, and thus
need to be marked "notrace".

Unfortunately, my naive assumption that gcc would see the inner
"notrace" does not hold.

Kudos to Lai Jiangshan for noting this.

Reported-by: Ingo Molnar <mingo@elte.hu>
Bug-spotted-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: laijs@cn.fujitsu.com
Cc: dipankar@in.ibm.com
Cc: akpm@linux-foundation.org
Cc: mathieu.desnoyers@polymtl.ca
Cc: josht@linux.vnet.ibm.com
Cc: dvhltc@us.ibm.com
Cc: niv@us.ibm.com
Cc: peterz@infradead.org
Cc: rostedt@goodmis.org
LKML-Reference: <12511321213243-git-send-email->
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 include/linux/rcupdate.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index ec90fc3..8b4422c 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -191,7 +191,7 @@ static inline void rcu_read_lock_sched(void)
 	__acquire(RCU_SCHED);
 	rcu_read_acquire();
 }
-static inline void rcu_read_lock_sched_notrace(void)
+static inline notrace void rcu_read_lock_sched_notrace(void)
 {
 	preempt_disable_notrace();
 	__acquire(RCU_SCHED);
@@ -209,7 +209,7 @@ static inline void rcu_read_unlock_sched(void)
 	__release(RCU_SCHED);
 	preempt_enable();
 }
-static inline void rcu_read_unlock_sched_notrace(void)
+static inline notrace void rcu_read_unlock_sched_notrace(void)
 {
 	rcu_read_release();
 	__release(RCU_SCHED);

  parent reply	other threads:[~2009-08-25  7:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-24 16:41 [PATCH -tip 0/2] Temporary RCU fixes for notrace and hotplug CPU Paul E. McKenney
2009-08-24 16:42 ` [PATCH -tip 1/2] Add "notrace" to RCU function headers used by ftrace Paul E. McKenney
2009-08-24 23:38   ` Steven Rostedt
2009-08-25  0:10     ` Mathieu Desnoyers
2009-08-25  2:02     ` Paul E. McKenney
2009-08-25  2:11       ` Steven Rostedt
2009-08-25  2:25         ` Paul E. McKenney
2009-08-25  7:13   ` tip-bot for Paul E. McKenney [this message]
2009-08-24 16:42 ` [PATCH -tip 2/2] Add CPU-offline processing for single-node configurations Paul E. McKenney
2009-08-25  7:13   ` [tip:core/rcu] rcu: " tip-bot for Paul E. McKenney
2009-08-25  6:55 ` [PATCH -tip 0/2] Temporary RCU fixes for notrace and hotplug CPU Ingo Molnar
2009-08-25  8:00   ` Ingo Molnar
2009-08-25 16:12     ` Paul E. McKenney
2009-08-25 16:25       ` Mathieu Desnoyers
2009-08-25 17:11         ` Paul E. McKenney
2009-08-25 18:02           ` Mathieu Desnoyers
2009-08-25 18:36             ` [PATCH -tip] " Paul E. McKenney
2009-08-26  0:53               ` Lai Jiangshan
2009-08-26  1:31                 ` Paul E. McKenney
2009-08-25 15:40   ` Paul E. McKenney
2009-08-25 18:19     ` Ingo Molnar
2009-08-25 18:41       ` Paul E. McKenney
2009-08-25 18:21     ` [tip:core/rcu] rcu: Add #ifdef to suppress __rcu_offline_cpu() warning in !HOTPLUG_CPU builds tip-bot for Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-7c614d6461399acca5c0ba444f5db49cb332fc08@git.kernel.org \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=hpa@zytor.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox