From: tip-bot for Daniel Lezcano <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
peterz@infradead.org, tglx@linutronix.de,
daniel.lezcano@linaro.org
Subject: [tip:sched/core] sched: Reduce trigger_load_balance() parameters
Date: Mon, 13 Jan 2014 07:55:29 -0800 [thread overview]
Message-ID: <tip-7caff66f361c44d0fbc74ed1cfa60a357fc84cf2@git.kernel.org> (raw)
In-Reply-To: <1389008085-9069-2-git-send-email-daniel.lezcano@linaro.org>
Commit-ID: 7caff66f361c44d0fbc74ed1cfa60a357fc84cf2
Gitweb: http://git.kernel.org/tip/7caff66f361c44d0fbc74ed1cfa60a357fc84cf2
Author: Daniel Lezcano <daniel.lezcano@linaro.org>
AuthorDate: Mon, 6 Jan 2014 12:34:38 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 13 Jan 2014 13:47:26 +0100
sched: Reduce trigger_load_balance() parameters
The cpu information is already stored in the struct rq, so no need to pass it
as parameter to the trigger_load_balance function.
Cc: linaro-kernel@lists.linaro.org
Cc: preeti.lkml@gmail.com
Cc: mingo@redhat.com
Cc: peterz@infradead.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1389008085-9069-2-git-send-email-daniel.lezcano@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/core.c | 2 +-
kernel/sched/fair.c | 4 +++-
kernel/sched/sched.h | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index a549d9a..392c6f8 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2436,7 +2436,7 @@ void scheduler_tick(void)
#ifdef CONFIG_SMP
rq->idle_balance = idle_cpu(cpu);
- trigger_load_balance(rq, cpu);
+ trigger_load_balance(rq);
#endif
rq_last_tick_reset(rq);
}
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b73f4ba..b35d322 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6876,8 +6876,10 @@ static inline int on_null_domain(int cpu)
/*
* Trigger the SCHED_SOFTIRQ if it is time to do periodic load balancing.
*/
-void trigger_load_balance(struct rq *rq, int cpu)
+void trigger_load_balance(struct rq *rq)
{
+ int cpu = rq->cpu;
+
/* Don't need to rebalance while attached to NULL domain */
if (time_after_eq(jiffies, rq->next_balance) &&
likely(!on_null_domain(cpu)))
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 890339099..c2119fd 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1175,7 +1175,7 @@ extern const struct sched_class idle_sched_class;
extern void update_group_power(struct sched_domain *sd, int cpu);
-extern void trigger_load_balance(struct rq *rq, int cpu);
+extern void trigger_load_balance(struct rq *rq);
extern void idle_balance(int this_cpu, struct rq *this_rq);
extern void idle_enter_fair(struct rq *this_rq);
next prev parent reply other threads:[~2014-01-13 15:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 11:34 [PATCH V2 0/8] sched: cleanup trigger_load_balance Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 1/8] sched: reduce trigger_load_balance parameters Daniel Lezcano
2014-01-13 15:55 ` tip-bot for Daniel Lezcano [this message]
2014-01-06 11:34 ` [PATCH V2 2/8] sched: reduce nohz_kick_needed parameters Daniel Lezcano
2014-01-13 15:55 ` [tip:sched/core] sched: Reduce nohz_kick_needed() parameters tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 3/8] sched: pass struct rq to on_null_domain function Daniel Lezcano
2014-01-13 15:55 ` [tip:sched/core] sched: Pass 'struct rq' to on_null_domain() tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 4/8] sched: remove unused parameter for find_new_ilb Daniel Lezcano
2014-01-13 15:55 ` [tip:sched/core] sched: Remove unused parameter from find_new_ilb () tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 5/8] sched: remove unused parameter in nohz_balancer_kick function Daniel Lezcano
2014-01-13 15:56 ` [tip:sched/core] sched: Remove unused parameter from nohz_balancer_kick() tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 6/8] sched: pass struct rq to rebalance_domains function Daniel Lezcano
2014-01-13 15:56 ` [tip:sched/core] sched: Pass 'struct rq' to rebalance_domains() tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 7/8] sched: pass struct rq to nohz_idle_balance function Daniel Lezcano
2014-01-13 15:56 ` [tip:sched/core] sched: Pass 'struct rq' to nohz_idle_balance() tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 8/8] sched: factor out on_null_domain check in trigger_load_balance function Daniel Lezcano
2014-01-13 15:56 ` [tip:sched/core] sched: Factor out the on_null_domain() checks in trigger_load_balance() tip-bot for Daniel Lezcano
2014-01-06 12:32 ` [PATCH V2 0/8] sched: cleanup trigger_load_balance Peter Zijlstra
2014-01-13 12:55 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-7caff66f361c44d0fbc74ed1cfa60a357fc84cf2@git.kernel.org \
--to=tipbot@zytor.com \
--cc=daniel.lezcano@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox