* VMI fix for stack protector
@ 2009-08-04 22:34 Alok Kataria
2009-08-05 9:57 ` [tip:x86/urgent] x86: Fix VMI && " tip-bot for Alok Kataria
0 siblings, 1 reply; 2+ messages in thread
From: Alok Kataria @ 2009-08-04 22:34 UTC (permalink / raw)
To: H. Peter Anvin, Ingo Molnar; +Cc: the arch/x86 maintainers, LKML, stable
With CONFIG_STACK_PROTECTOR turned on, VMI doesn't boot with more than one
processor. The problem is with the gs value not being initialized correctly
when registering the secondary processor for VMI's case.
The patch below initializes the gs value for the AP to __KERNEL_STACK_CANARY.
Without this the secondary processor keeps on taking a GP on every gs access.
Needs to go in for 2.6.30.x too, since STACK_PROTECTOR for 32bit was
introduced in 2.6.30.
Patch on top of 2.6.31-rc5.
Signed-off-by: Alok N Kataria <akataria@vmware.com>
Cc: stable@kernel.org
Index: linux-2.6/arch/x86/kernel/vmi_32.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/vmi_32.c 2009-08-03 13:55:41.000000000 -0700
+++ linux-2.6/arch/x86/kernel/vmi_32.c 2009-08-04 14:13:22.000000000 -0700
@@ -442,7 +442,7 @@ vmi_startup_ipi_hook(int phys_apicid, un
ap.ds = __USER_DS;
ap.es = __USER_DS;
ap.fs = __KERNEL_PERCPU;
- ap.gs = 0;
+ ap.gs = __KERNEL_STACK_CANARY;
ap.eflags = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/urgent] x86: Fix VMI && stack protector
2009-08-04 22:34 VMI fix for stack protector Alok Kataria
@ 2009-08-05 9:57 ` tip-bot for Alok Kataria
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Alok Kataria @ 2009-08-05 9:57 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, akataria, tglx, mingo
Commit-ID: 7d5b005652bc5ae3e1e0efc53fd0e25a643ec506
Gitweb: http://git.kernel.org/tip/7d5b005652bc5ae3e1e0efc53fd0e25a643ec506
Author: Alok Kataria <akataria@vmware.com>
AuthorDate: Tue, 4 Aug 2009 15:34:22 -0700
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 5 Aug 2009 10:20:29 +0200
x86: Fix VMI && stack protector
With CONFIG_STACK_PROTECTOR turned on, VMI doesn't boot with
more than one processor. The problem is with the gs value not
being initialized correctly when registering the secondary
processor for VMI's case.
The patch below initializes the gs value for the AP to
__KERNEL_STACK_CANARY. Without this the secondary processor
keeps on taking a GP on every gs access.
Signed-off-by: Alok N Kataria <akataria@vmware.com>
Cc: <stable@kernel.org> # for v2.6.30.x
LKML-Reference: <1249425262.18955.40.camel@ank32.eng.vmware.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/vmi_32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/vmi_32.c b/arch/x86/kernel/vmi_32.c
index b263423..95a7289 100644
--- a/arch/x86/kernel/vmi_32.c
+++ b/arch/x86/kernel/vmi_32.c
@@ -441,7 +441,7 @@ vmi_startup_ipi_hook(int phys_apicid, unsigned long start_eip,
ap.ds = __USER_DS;
ap.es = __USER_DS;
ap.fs = __KERNEL_PERCPU;
- ap.gs = 0;
+ ap.gs = __KERNEL_STACK_CANARY;
ap.eflags = 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-05 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-04 22:34 VMI fix for stack protector Alok Kataria
2009-08-05 9:57 ` [tip:x86/urgent] x86: Fix VMI && " tip-bot for Alok Kataria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox