public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Vladimir Davydov <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	peterz@infradead.org, pjt@google.com, tglx@linutronix.de,
	vdavydov@parallels.com
Subject: [tip:sched/core] sched/balancing: Fix cfs_rq-> task_h_load calculation
Date: Fri, 20 Sep 2013 06:46:59 -0700	[thread overview]
Message-ID: <tip-7e3115ef5149fc502e3a2e80719dba54a8e7409d@git.kernel.org> (raw)
In-Reply-To: <1379173186-11944-1-git-send-email-vdavydov@parallels.com>

Commit-ID:  7e3115ef5149fc502e3a2e80719dba54a8e7409d
Gitweb:     http://git.kernel.org/tip/7e3115ef5149fc502e3a2e80719dba54a8e7409d
Author:     Vladimir Davydov <vdavydov@parallels.com>
AuthorDate: Sat, 14 Sep 2013 19:39:46 +0400
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 20 Sep 2013 11:59:39 +0200

sched/balancing: Fix cfs_rq->task_h_load calculation

Patch a003a2 (sched: Consider runnable load average in move_tasks())
sets all top-level cfs_rqs' h_load to rq->avg.load_avg_contrib, which is
always 0. This mistype leads to all tasks having weight 0 when load
balancing in a cpu-cgroup enabled setup. There obviously should be sum
of weights of all runnable tasks there instead. Fix it.

Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
Reviewed-by: Paul Turner <pjt@google.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1379173186-11944-1-git-send-email-vdavydov@parallels.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 2aedacc..7c70201 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4242,7 +4242,7 @@ static void update_cfs_rq_h_load(struct cfs_rq *cfs_rq)
 	}
 
 	if (!se) {
-		cfs_rq->h_load = rq->avg.load_avg_contrib;
+		cfs_rq->h_load = cfs_rq->runnable_load_avg;
 		cfs_rq->last_h_load_update = now;
 	}
 

  parent reply	other threads:[~2013-09-20 13:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-14 15:39 [PATCH] sched: Fix task_h_load calculation Vladimir Davydov
2013-09-14 18:52 ` Paul Turner
2013-09-20 13:46 ` tip-bot for Vladimir Davydov [this message]
2013-09-29  9:47   ` [tip:sched/core] sched/balancing: Fix cfs_rq-> " Yuanhan Liu
2013-09-30  8:14     ` Vladimir Davydov
2013-10-01  2:22       ` Yuanhan Liu
2013-10-01  2:32         ` Paul Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-7e3115ef5149fc502e3a2e80719dba54a8e7409d@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=tglx@linutronix.de \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox