public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for zhangdianfang <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, acme@redhat.com, hpa@zytor.com,
	mingo@kernel.org, jolsa@kernel.org, zhangdianfang@huawei.com,
	jdelvare@suse.de, dcb314@hotmail.com, tglx@linutronix.de
Subject: [tip:perf/core] perf tools: Fix "==" into "=" in ui_browser__warning assignment
Date: Thu, 5 Jun 2014 07:31:38 -0700	[thread overview]
Message-ID: <tip-7f3e508ee1e6cc1b5865edcbf04a14a76ff1534c@git.kernel.org> (raw)
In-Reply-To: <20140530154709.GC1202@kernel.org>

Commit-ID:  7f3e508ee1e6cc1b5865edcbf04a14a76ff1534c
Gitweb:     http://git.kernel.org/tip/7f3e508ee1e6cc1b5865edcbf04a14a76ff1534c
Author:     zhangdianfang <zhangdianfang@huawei.com>
AuthorDate: Fri, 30 May 2014 08:53:58 +0800
Committer:  Jiri Olsa <jolsa@kernel.org>
CommitDate: Tue, 3 Jun 2014 21:34:48 +0200

perf tools: Fix "==" into "=" in ui_browser__warning assignment

Convert "==" into "=" in ui_browser__warning assignment.

Bug description: https://bugzilla.kernel.org/show_bug.cgi?id=76751

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Dianfang Zhang <zhangdianfang@huawei.com>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jean Delvare <jdelvare@suse.de>
Link: http://lkml.kernel.org/r/20140530154709.GC1202@kernel.org
[ changed the changelog a bit ]
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/ui/browser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index d11541d..3ccf6e1 100644
--- a/tools/perf/ui/browser.c
+++ b/tools/perf/ui/browser.c
@@ -194,7 +194,7 @@ int ui_browser__warning(struct ui_browser *browser, int timeout,
 		ui_helpline__vpush(format, args);
 		va_end(args);
 	} else {
-		while ((key == ui__question_window("Warning!", text,
+		while ((key = ui__question_window("Warning!", text,
 						   "Press any key...",
 						   timeout)) == K_RESIZE)
 			ui_browser__handle_resize(browser);

      parent reply	other threads:[~2014-06-05 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5387D6A6.20703@huawei.com>
     [not found] ` <20140530144446.1b4586f5@endymion.delvare>
     [not found]   ` <20140530152011.GA1202@kernel.org>
     [not found]     ` <20140530153729.GE7427@krava.brq.redhat.com>
2014-05-30 15:47       ` [PATCH] toosl/perf: convert "==" into "=" Arnaldo Carvalho de Melo
2014-05-30 15:55         ` Peter Zijlstra
2014-06-03  2:57         ` Namhyung Kim
2014-06-05 14:31         ` tip-bot for zhangdianfang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-7f3e508ee1e6cc1b5865edcbf04a14a76ff1534c@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=dcb314@hotmail.com \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.de \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=zhangdianfang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox