From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752662AbdIVQqh (ORCPT ); Fri, 22 Sep 2017 12:46:37 -0400 Received: from terminus.zytor.com ([65.50.211.136]:47245 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752517AbdIVQqf (ORCPT ); Fri, 22 Sep 2017 12:46:35 -0400 Date: Fri, 22 Sep 2017 09:42:54 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: linux-kernel@vger.kernel.org, ak@linux.intel.com, mingo@kernel.org, dsahern@gmail.com, wangnan0@huawei.com, hpa@zytor.com, peterz@infradead.org, acme@redhat.com, lukasz.odzioba@intel.com, kan.liang@intel.com, adrian.hunter@intel.com, namhyung@kernel.org, jolsa@kernel.org, tglx@linutronix.de Reply-To: lukasz.odzioba@intel.com, kan.liang@intel.com, tglx@linutronix.de, jolsa@kernel.org, adrian.hunter@intel.com, namhyung@kernel.org, ak@linux.intel.com, linux-kernel@vger.kernel.org, mingo@kernel.org, dsahern@gmail.com, hpa@zytor.com, wangnan0@huawei.com, acme@redhat.com, peterz@infradead.org To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf machine: Optimize a bit the machine__findnew_thread() methods Git-Commit-ID: 75e45e432052c7b1a5da866cff88192db8be1445 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 75e45e432052c7b1a5da866cff88192db8be1445 Gitweb: http://git.kernel.org/tip/75e45e432052c7b1a5da866cff88192db8be1445 Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 14 Sep 2017 16:16:34 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 18 Sep 2017 09:40:19 -0300 perf machine: Optimize a bit the machine__findnew_thread() methods In some cases we already have calculated the hash bucket, so reuse it. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jiri Olsa Cc: Kan Liang Cc: Lukasz Odzioba Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-800zehjsyy03er4s4jf0e99v@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/machine.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index f4f9267..ddeea05 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -399,10 +399,10 @@ out_err: * lookup/new thread inserted. */ static struct thread *____machine__findnew_thread(struct machine *machine, + struct threads *threads, pid_t pid, pid_t tid, bool create) { - struct threads *threads = machine__threads(machine, tid); struct rb_node **p = &threads->entries.rb_node; struct rb_node *parent = NULL; struct thread *th; @@ -473,7 +473,7 @@ static struct thread *____machine__findnew_thread(struct machine *machine, struct thread *__machine__findnew_thread(struct machine *machine, pid_t pid, pid_t tid) { - return ____machine__findnew_thread(machine, pid, tid, true); + return ____machine__findnew_thread(machine, machine__threads(machine, tid), pid, tid, true); } struct thread *machine__findnew_thread(struct machine *machine, pid_t pid, @@ -495,7 +495,7 @@ struct thread *machine__find_thread(struct machine *machine, pid_t pid, struct thread *th; pthread_rwlock_rdlock(&threads->lock); - th = ____machine__findnew_thread(machine, pid, tid, false); + th = ____machine__findnew_thread(machine, threads, pid, tid, false); pthread_rwlock_unlock(&threads->lock); return th; }