From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754428AbcB2LUj (ORCPT ); Mon, 29 Feb 2016 06:20:39 -0500 Received: from torg.zytor.com ([198.137.202.12]:54660 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753802AbcB2LUf (ORCPT ); Mon, 29 Feb 2016 06:20:35 -0500 Date: Mon, 29 Feb 2016 03:19:42 -0800 From: tip-bot for Peter Zijlstra Message-ID: Cc: luca.abeni@unitn.it, torvalds@linux-foundation.org, tglx@linutronix.de, hpa@zytor.com, efault@gmx.de, linux-kernel@vger.kernel.org, juri.lelli@arm.com, mingo@kernel.org, peterz@infradead.org Reply-To: luca.abeni@unitn.it, efault@gmx.de, tglx@linutronix.de, torvalds@linux-foundation.org, hpa@zytor.com, juri.lelli@arm.com, mingo@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20160225140149.GK6357@twins.programming.kicks-ass.net> References: <20160225140149.GK6357@twins.programming.kicks-ass.net> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/deadline: Remove superfluous call to switched_to_dl() Git-Commit-ID: 801ccdbf018ca5dbd478756ece55cd6c7726ed5b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 801ccdbf018ca5dbd478756ece55cd6c7726ed5b Gitweb: http://git.kernel.org/tip/801ccdbf018ca5dbd478756ece55cd6c7726ed5b Author: Peter Zijlstra AuthorDate: Thu, 25 Feb 2016 15:01:49 +0100 Committer: Ingo Molnar CommitDate: Mon, 29 Feb 2016 09:53:11 +0100 sched/deadline: Remove superfluous call to switched_to_dl() if (A || B) { } else if (A && !B) { } If A we'll take the first branch, if !A we will not satisfy the second. Therefore the second branch will never be taken. Reported-by: luca abeni Signed-off-by: Peter Zijlstra (Intel) Acked-by: Juri Lelli Cc: Linus Torvalds Cc: Mike Galbraith Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20160225140149.GK6357@twins.programming.kicks-ass.net Signed-off-by: Ingo Molnar --- kernel/sched/deadline.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 04a569c..15abf04 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -1772,8 +1772,7 @@ static void prio_changed_dl(struct rq *rq, struct task_struct *p, */ resched_curr(rq); #endif /* CONFIG_SMP */ - } else - switched_to_dl(rq, p); + } } const struct sched_class dl_sched_class = {