From: tip-bot for Tommi Rantala <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, paulus@samba.org, hpa@zytor.com,
mingo@kernel.org, a.p.zijlstra@chello.nl,
acme@ghostprotocols.net, tglx@linutronix.de,
tt.rantala@gmail.com
Subject: [tip:perf/urgent] perf: Treat attr.config as u64 in perf_swevent_init()
Date: Mon, 15 Apr 2013 03:42:01 -0700 [thread overview]
Message-ID: <tip-8176cced706b5e5d15887584150764894e94e02f@git.kernel.org> (raw)
In-Reply-To: <1365882554-30259-1-git-send-email-tt.rantala@gmail.com>
Commit-ID: 8176cced706b5e5d15887584150764894e94e02f
Gitweb: http://git.kernel.org/tip/8176cced706b5e5d15887584150764894e94e02f
Author: Tommi Rantala <tt.rantala@gmail.com>
AuthorDate: Sat, 13 Apr 2013 22:49:14 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 15 Apr 2013 11:42:12 +0200
perf: Treat attr.config as u64 in perf_swevent_init()
Trinity discovered that we fail to check all 64 bits of
attr.config passed by user space, resulting to out-of-bounds
access of the perf_swevent_enabled array in
sw_perf_event_destroy().
Introduced in commit b0a873ebb ("perf: Register PMU
implementations").
Signed-off-by: Tommi Rantala <tt.rantala@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: davej@redhat.com
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Link: http://lkml.kernel.org/r/1365882554-30259-1-git-send-email-tt.rantala@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/events/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 7e0962e..4d3124b 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -5331,7 +5331,7 @@ static void sw_perf_event_destroy(struct perf_event *event)
static int perf_swevent_init(struct perf_event *event)
{
- int event_id = event->attr.config;
+ u64 event_id = event->attr.config;
if (event->attr.type != PERF_TYPE_SOFTWARE)
return -ENOENT;
next prev parent reply other threads:[~2013-04-15 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 19:49 [PATCH] perf: treat attr.config as u64 in perf_swevent_init() Tommi Rantala
2013-04-15 10:42 ` tip-bot for Tommi Rantala [this message]
2013-04-18 11:17 ` [tip:perf/urgent] perf: Treat " Peter Zijlstra
2013-04-22 12:33 ` Vince Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-8176cced706b5e5d15887584150764894e94e02f@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=tt.rantala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox