From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, paulus@samba.org, acme@redhat.com,
hpa@zytor.com, mingo@kernel.org, jolsa@kernel.org,
a.p.zijlstra@chello.nl, peterz@infradead.org, acme@kernel.org,
namhyung@kernel.org, fweisbec@gmail.com, dsahern@gmail.com,
tglx@linutronix.de, cjashfor@linux.vnet.ibm.com, bp@suse.de
Subject: [tip:perf/core] perf tools: Move sys_perf_event_open function from perf.h
Date: Mon, 5 May 2014 10:49:38 -0700 [thread overview]
Message-ID: <tip-82baa0eb46c15b749723d0c801470fea044657d7@git.kernel.org> (raw)
In-Reply-To: <1399293219-8732-10-git-send-email-jolsa@kernel.org>
Commit-ID: 82baa0eb46c15b749723d0c801470fea044657d7
Gitweb: http://git.kernel.org/tip/82baa0eb46c15b749723d0c801470fea044657d7
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Mon, 5 May 2014 12:58:31 +0200
Committer: Jiri Olsa <jolsa@kernel.org>
CommitDate: Mon, 5 May 2014 17:48:51 +0200
perf tools: Move sys_perf_event_open function from perf.h
Into perf-sys.h header, as requested by Peter:
http://lkml.kernel.org/r/20140502115201.GI30445@twins.programming.kicks-ass.net
Adding HAVE_ATTR_TEST define to turn off/on the attribute
test code in the sys_perf_event_open function.
Requested-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Borislav Petkov <bp@suse.de>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1399293219-8732-10-git-send-email-jolsa@kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/perf-sys.h | 22 ++++++++++++++++++++++
tools/perf/perf.h | 40 +++++++++++-----------------------------
2 files changed, 33 insertions(+), 29 deletions(-)
diff --git a/tools/perf/perf-sys.h b/tools/perf/perf-sys.h
index 4c22c2a..5268a14 100644
--- a/tools/perf/perf-sys.h
+++ b/tools/perf/perf-sys.h
@@ -1,6 +1,11 @@
#ifndef _PERF_SYS_H
#define _PERF_SYS_H
+#include <unistd.h>
+#include <sys/types.h>
+#include <sys/syscall.h>
+#include <linux/types.h>
+#include <linux/perf_event.h>
#include <asm/unistd.h>
#if defined(__i386__)
@@ -165,4 +170,21 @@
#define cpu_relax() barrier()
#endif
+static inline int
+sys_perf_event_open(struct perf_event_attr *attr,
+ pid_t pid, int cpu, int group_fd,
+ unsigned long flags)
+{
+ int fd;
+
+ fd = syscall(__NR_perf_event_open, attr, pid, cpu,
+ group_fd, flags);
+
+#ifdef HAVE_ATTR_TEST
+ if (unlikely(test_attr__enabled))
+ test_attr__open(attr, pid, cpu, fd, group_fd, flags);
+#endif
+ return fd;
+}
+
#endif /* _PERF_SYS_H */
diff --git a/tools/perf/perf.h b/tools/perf/perf.h
index ee95965..813571b 100644
--- a/tools/perf/perf.h
+++ b/tools/perf/perf.h
@@ -1,18 +1,21 @@
#ifndef _PERF_PERF_H
#define _PERF_PERF_H
-#include "perf-sys.h"
-
-#define ACCESS_ONCE(x) (*(volatile typeof(x) *)&(x))
-
#include <time.h>
-#include <unistd.h>
-#include <sys/types.h>
-#include <sys/syscall.h>
-
+#include <stdbool.h>
#include <linux/types.h>
#include <linux/perf_event.h>
+extern bool test_attr__enabled;
+void test_attr__init(void);
+void test_attr__open(struct perf_event_attr *attr, pid_t pid, int cpu,
+ int fd, int group_fd, unsigned long flags);
+
+#define HAVE_ATTR_TEST
+#include "perf-sys.h"
+
+#define ACCESS_ONCE(x) (*(volatile typeof(x) *)&(x))
+
#ifndef NSEC_PER_SEC
# define NSEC_PER_SEC 1000000000ULL
#endif
@@ -28,27 +31,6 @@ static inline unsigned long long rdclock(void)
return ts.tv_sec * 1000000000ULL + ts.tv_nsec;
}
-extern bool test_attr__enabled;
-void test_attr__init(void);
-void test_attr__open(struct perf_event_attr *attr, pid_t pid, int cpu,
- int fd, int group_fd, unsigned long flags);
-
-static inline int
-sys_perf_event_open(struct perf_event_attr *attr,
- pid_t pid, int cpu, int group_fd,
- unsigned long flags)
-{
- int fd;
-
- fd = syscall(__NR_perf_event_open, attr, pid, cpu,
- group_fd, flags);
-
- if (unlikely(test_attr__enabled))
- test_attr__open(attr, pid, cpu, fd, group_fd, flags);
-
- return fd;
-}
-
#define MAX_NR_CPUS 256
extern const char *input_name;
next prev parent reply other threads:[~2014-05-05 17:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 12:33 [PATCH 00/10] perf tools: perf.h cleanups Jiri Olsa
2014-05-05 12:33 ` [PATCH 01/10] perf tools: Remove MAX_COUNTERS define from perf.h Jiri Olsa
2014-05-05 17:47 ` [tip:perf/core] " tip-bot for Jiri Olsa
2014-05-05 12:33 ` [PATCH 02/10] perf tools: Remove unlikely " Jiri Olsa
2014-05-05 17:48 ` [tip:perf/core] " tip-bot for Jiri Olsa
2014-05-05 12:33 ` [PATCH 03/10] perf tools: Remove min " Jiri Olsa
2014-05-05 17:48 ` [tip:perf/core] " tip-bot for Jiri Olsa
2014-05-05 12:33 ` [PATCH 04/10] perf tools: Remove asmlinkage " Jiri Olsa
2014-05-05 17:48 ` [tip:perf/core] " tip-bot for Jiri Olsa
2014-05-05 12:33 ` [PATCH 05/10] perf tools: Remove PR_TASK_PERF_EVENTS_* " Jiri Olsa
2014-05-05 17:48 ` [tip:perf/core] " tip-bot for Jiri Olsa
2014-05-05 12:33 ` [PATCH 06/10] perf tools: Move sample data structures " Jiri Olsa
2014-05-05 17:48 ` [tip:perf/core] " tip-bot for Jiri Olsa
2014-05-05 12:33 ` [PATCH 07/10] perf tools: Move perf_call_graph_mode enum " Jiri Olsa
2014-05-05 17:49 ` [tip:perf/core] " tip-bot for Jiri Olsa
2014-05-05 12:33 ` [PATCH 08/10] perf tools: Move syscall and arch specific defines " Jiri Olsa
2014-05-05 17:49 ` [tip:perf/core] " tip-bot for Jiri Olsa
2014-05-05 12:33 ` [PATCH 09/10] perf tools: Move sys_perf_event_open function " Jiri Olsa
2014-05-05 17:49 ` tip-bot for Jiri Olsa [this message]
2014-05-05 12:33 ` [PATCH 10/10] perf tools: Move ACCESS_ONCE from perf.h header Jiri Olsa
2014-05-05 12:45 ` Peter Zijlstra
2014-05-05 12:59 ` Borislav Petkov
2014-05-05 13:13 ` Jiri Olsa
2014-05-05 12:46 ` [PATCH 00/10] perf tools: perf.h cleanups Peter Zijlstra
2014-05-05 13:49 ` Arnaldo Carvalho de Melo
2014-05-05 13:59 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-82baa0eb46c15b749723d0c801470fea044657d7@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=bp@suse.de \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox