From: tip-bot for Borislav Petkov <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, bp@suse.de,
fanc.fnst@cn.fujitsu.com, linux-kernel@vger.kernel.org,
lkp@intel.com
Subject: [tip:x86/boot] x86/boot: Fix cmdline_find_option() prototype visibility
Date: Wed, 6 Feb 2019 02:55:35 -0800 [thread overview]
Message-ID: <tip-82f9ed3a93307089242ff8a5c694e82c8c93f522@git.kernel.org> (raw)
In-Reply-To: <20190205131352.GA27396@zn.tnic>
Commit-ID: 82f9ed3a93307089242ff8a5c694e82c8c93f522
Gitweb: https://git.kernel.org/tip/82f9ed3a93307089242ff8a5c694e82c8c93f522
Author: Borislav Petkov <bp@suse.de>
AuthorDate: Tue, 5 Feb 2019 12:05:45 +0100
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Wed, 6 Feb 2019 11:41:21 +0100
x86/boot: Fix cmdline_find_option() prototype visibility
ac09c5f43cf6 ("x86/boot: Build the command line parsing code unconditionally")
enabled building the command line parsing code unconditionally but it
forgot to remove the respective ifdeffery around the prototypes in the
misc.h header, leading to
arch/x86/boot/compressed/acpi.c: In function ‘get_acpi_rsdp’:
arch/x86/boot/compressed/acpi.c:37:8: warning: implicit declaration of function \
‘cmdline_find_option’ [-Wimplicit-function-declaration]
ret = cmdline_find_option("acpi_rsdp", val, MAX_ADDR_LEN);
^~~~~~~~~~~~~~~~~~~
for configs where neither CONFIG_EARLY_PRINTK nor CONFIG_RANDOMIZE_BASE
was defined.
Drop the ifdeffery in the header too.
Fixes: ac09c5f43cf6 ("x86/boot: Build the command line parsing code unconditionally")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Chao Fan <fanc.fnst@cn.fujitsu.com>
Cc: x86@kernel.org
Link: https://lkml.kernel.org/r/5c51daf0.83pQEkvDZILqoSYW%lkp@intel.com
Link: https://lkml.kernel.org/r/20190205131352.GA27396@zn.tnic
---
arch/x86/boot/compressed/misc.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h
index 19e8231a6fd6..5b8d51996cdd 100644
--- a/arch/x86/boot/compressed/misc.h
+++ b/arch/x86/boot/compressed/misc.h
@@ -66,11 +66,9 @@ static inline void debug_puthex(const char *s)
#endif
-#if CONFIG_EARLY_PRINTK || CONFIG_RANDOMIZE_BASE
/* cmdline.c */
int cmdline_find_option(const char *option, char *buffer, int bufsize);
int cmdline_find_option_bool(const char *option);
-#endif
struct mem_vector {
unsigned long long start;
prev parent reply other threads:[~2019-02-06 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5c51daf0.83pQEkvDZILqoSYW%lkp@intel.com>
[not found] ` <20190130172019.GD21221@zn.tnic>
2019-02-05 13:13 ` [PATCH] x86/boot: Fix cmdline_find_option() prototype visibility Borislav Petkov
2019-02-06 10:55 ` tip-bot for Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-82f9ed3a93307089242ff8a5c694e82c8c93f522@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bp@suse.de \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox