From: tip-bot for Gui Jianfeng <guijianfeng@cn.fujitsu.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
mingo@redhat.com, a.p.zijlstra@chello.nl,
yanmin_zhang@linux.intel.com, guijianfeng@cn.fujitsu.com,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perf/core] perf kvm: Get rid of unused guest_kallsyms
Date: Fri, 25 Jun 2010 15:29:12 GMT [thread overview]
Message-ID: <tip-830f4c803196eec181e209110885c4ac130f3805@git.kernel.org> (raw)
In-Reply-To: <4C241140.9090008@cn.fujitsu.com>
Commit-ID: 830f4c803196eec181e209110885c4ac130f3805
Gitweb: http://git.kernel.org/tip/830f4c803196eec181e209110885c4ac130f3805
Author: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
AuthorDate: Fri, 25 Jun 2010 10:15:28 +0800
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 25 Jun 2010 07:28:21 -0300
perf kvm: Get rid of unused guest_kallsyms
guest_kallsyms is redundant here, remove it.
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Yanmin Zhang <yanmin_zhang@linux.intel.com>
LKML-Reference: <4C241140.9090008@cn.fujitsu.com>
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-record.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 86b1c3b..0df6408 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -445,8 +445,6 @@ static void atexit_header(void)
static void event__synthesize_guest_os(struct machine *machine, void *data)
{
int err;
- char *guest_kallsyms;
- char path[PATH_MAX];
struct perf_session *psession = data;
if (machine__is_host(machine))
@@ -466,13 +464,6 @@ static void event__synthesize_guest_os(struct machine *machine, void *data)
pr_err("Couldn't record guest kernel [%d]'s reference"
" relocation symbol.\n", machine->pid);
- if (machine__is_default_guest(machine))
- guest_kallsyms = (char *) symbol_conf.default_guest_kallsyms;
- else {
- sprintf(path, "%s/proc/kallsyms", machine->root_dir);
- guest_kallsyms = path;
- }
-
/*
* We use _stext for guest kernel because guest kernel's /proc/kallsyms
* have no _text sometimes.
prev parent reply other threads:[~2010-06-25 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 2:15 [PATCH 1/3] perf kvm: Get rid of unused guest_kallsyms Gui Jianfeng
2010-06-25 2:16 ` [PATCH 2/3] perf: Remove dead code in buildin-record.c Gui Jianfeng
2010-06-25 13:13 ` Arnaldo Carvalho de Melo
2010-06-25 14:48 ` Peter Zijlstra
2010-06-26 15:14 ` Matt Fleming
2010-06-26 18:12 ` Arnaldo Carvalho de Melo
2010-07-18 20:06 ` Matt Fleming
2010-08-04 10:56 ` Peter Zijlstra
2010-08-04 11:25 ` Matt Fleming
2010-06-25 2:18 ` [PATCH 3/3] perf: Fix the bug which fails to put memory mapping to record file Gui Jianfeng
2010-06-25 15:29 ` tip-bot for Gui Jianfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-830f4c803196eec181e209110885c4ac130f3805@git.kernel.org \
--to=guijianfeng@cn.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox