Re: [PATCH 4/4] perf stat: Add transaction flag (-T) support for s390

Thomas-Mich Richter
2018-06-22T08:12:07Z

On 06/22/2018 04:36 AM, Andi Kleen wrote:
> Thomas Richter <tmricht@linux.ibm.com> writes:
>>
>> + /* Handle -T as -M transaction. Once platform specific metrics
>> + * support has been added to the json files, all archiectures
>> + * will use this approach.
>> + */
>> + if (!strcmp(perf_env__arch(NULL), "s390")) {
>
> Use pmu_have_event() instead.

Done see version v2

>
> You may need to add support for wildcard pmus to it.
>
> -Andi
>

Currently only one PMU on s390 does support transactions, its the PMU with counters
named cpum_cf.

--
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294