The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: tip-bot for Peter Zijlstra <a.p.zijlstra@chello.nl>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	a.p.zijlstra@chello.nl, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perf/core] x86: Move notify_cpu_starting() callback to a later stage
Date: Fri, 2 Apr 2010 19:06:56 GMT	[thread overview]
Message-ID: <tip-85257024096a96fc5c00ce59d685f62bbed3ad95@git.kernel.org> (raw)
In-Reply-To: <1269353485.5109.48.camel@twins>

Commit-ID:  85257024096a96fc5c00ce59d685f62bbed3ad95
Gitweb:     http://git.kernel.org/tip/85257024096a96fc5c00ce59d685f62bbed3ad95
Author:     Peter Zijlstra <a.p.zijlstra@chello.nl>
AuthorDate: Tue, 23 Mar 2010 19:30:52 +0100
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 2 Apr 2010 19:30:01 +0200

x86: Move notify_cpu_starting() callback to a later stage

Because we need to have cpu identification things done by the time we run
CPU_STARTING notifiers.

( This init ordering will be relied on by the next fix. )

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1269353485.5109.48.camel@twins>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/smpboot.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 06d98ae..6808b93 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -242,8 +242,6 @@ static void __cpuinit smp_callin(void)
 	end_local_APIC_setup();
 	map_cpu_to_logical_apicid();
 
-	notify_cpu_starting(cpuid);
-
 	/*
 	 * Need to setup vector mappings before we enable interrupts.
 	 */
@@ -264,6 +262,8 @@ static void __cpuinit smp_callin(void)
 	 */
 	smp_store_cpu_info(cpuid);
 
+	notify_cpu_starting(cpuid);
+
 	/*
 	 * Allow the master to continue.
 	 */

  parent reply	other threads:[~2010-04-02 19:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-17  8:40 [PATCH] perf_events: fix bug in AMD per-cpu initialization Stephane Eranian
2010-03-17 23:47 ` Peter Zijlstra
2010-03-18  0:33   ` Stephane Eranian
2010-03-23 14:11     ` Peter Zijlstra
2010-03-23 14:55       ` Stephane Eranian
2010-03-23 15:07         ` Peter Zijlstra
2010-03-23 15:12           ` Stephane Eranian
2010-03-23 15:18             ` Peter Zijlstra
2010-03-23 22:41               ` Stephane Eranian
2010-04-02 19:06       ` tip-bot for Peter Zijlstra [this message]
2010-04-02 19:07       ` [tip:perf/core] perf, x86: Fix AMD hotplug & constraint initialization tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-85257024096a96fc5c00ce59d685f62bbed3ad95@git.kernel.org \
    --to=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox