public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Marti Raudsepp <marti@juffo.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, paulus@samba.org, hpa@zytor.com,
	mingo@redhat.com, a.p.zijlstra@chello.nl, marti@juffo.org,
	tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perf/core] perf tools: Notify user when unrecognized event is specified
Date: Tue, 27 Oct 2009 13:54:34 GMT	[thread overview]
Message-ID: <tip-85df6f683efa457440eb922272fd5a71aa022ad4@git.kernel.org> (raw)
In-Reply-To: <03ec9ee96f17cef05424.1256603584@localhost>

Commit-ID:  85df6f683efa457440eb922272fd5a71aa022ad4
Gitweb:     http://git.kernel.org/tip/85df6f683efa457440eb922272fd5a71aa022ad4
Author:     Marti Raudsepp <marti@juffo.org>
AuthorDate: Tue, 27 Oct 2009 00:33:04 +0000
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 27 Oct 2009 14:52:31 +0100

perf tools: Notify user when unrecognized event is specified

Previously no indication was given about what went wrong.

Signed-off-by: Marti Raudsepp <marti@juffo.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <03ec9ee96f17cef05424.1256603584@localhost>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 tools/perf/util/parse-events.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index b097570..e9e6d5c 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -678,6 +678,8 @@ parse_event_symbols(const char **str, struct perf_event_attr *attr)
 	if (ret != EVT_FAILED)
 		goto modifier;
 
+	fprintf(stderr, "invalid or unsupported event: '%s'\n", *str);
+	fprintf(stderr, "Run 'perf list' for a list of valid events\n");
 	return EVT_FAILED;
 
 modifier:

  reply	other threads:[~2009-10-27 13:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-27  0:33 [PATCH 0 of 2] Two small UI tweaks to perf Marti Raudsepp
2009-10-27  0:33 ` [PATCH 1 of 2] perf tools: notify user when unrecognized event is specified Marti Raudsepp
2009-10-27 13:54   ` tip-bot for Marti Raudsepp [this message]
2009-10-27  0:33 ` [PATCH 2 of 2] perf tools: output 'perf list' to stdout not stderr Marti Raudsepp
2009-10-27 13:54   ` [tip:perf/core] perf tools: Output " tip-bot for Marti Raudsepp
2009-10-27 13:52 ` [PATCH 0 of 2] Two small UI tweaks to perf Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-85df6f683efa457440eb922272fd5a71aa022ad4@git.kernel.org \
    --to=marti@juffo.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox