From: tip-bot for Thomas Gleixner <tglx@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
peterz@infradead.org, tglx@linutronix.de
Subject: [tip:smp/hotplug] x86: Use kick_all_cpus_sync()
Date: Tue, 8 May 2012 05:27:47 -0700 [thread overview]
Message-ID: <tip-85f7f656274fa0ba109dd8774db3887d42de5c6b@git.kernel.org> (raw)
In-Reply-To: <20120507175652.190382227@linutronix.de>
Commit-ID: 85f7f656274fa0ba109dd8774db3887d42de5c6b
Gitweb: http://git.kernel.org/tip/85f7f656274fa0ba109dd8774db3887d42de5c6b
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Mon, 7 May 2012 17:59:49 +0000
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 8 May 2012 12:35:06 +0200
x86: Use kick_all_cpus_sync()
Use kick_all_cpus_sync() and remove cpu_idle_wait().
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20120507175652.190382227@linutronix.de
Cc: x86@kernel.org
---
arch/x86/Kconfig | 3 ---
arch/x86/include/asm/processor.h | 2 --
arch/x86/kernel/apm_32.c | 2 +-
arch/x86/kernel/process.c | 20 --------------------
4 files changed, 1 insertions(+), 26 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 046bf4b..98876f5 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -161,9 +161,6 @@ config RWSEM_GENERIC_SPINLOCK
config RWSEM_XCHGADD_ALGORITHM
def_bool X86_XADD
-config ARCH_HAS_CPU_IDLE_WAIT
- def_bool y
-
config GENERIC_CALIBRATE_DELAY
def_bool y
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index 4fa7dcc..ccbb1ea 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -974,8 +974,6 @@ extern bool cpu_has_amd_erratum(const int *);
#define cpu_has_amd_erratum(x) (false)
#endif /* CONFIG_CPU_SUP_AMD */
-void cpu_idle_wait(void);
-
extern unsigned long arch_align_stack(unsigned long sp);
extern void free_init_pages(char *what, unsigned long begin, unsigned long end);
diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
index 459e78c..07b0c0d 100644
--- a/arch/x86/kernel/apm_32.c
+++ b/arch/x86/kernel/apm_32.c
@@ -2401,7 +2401,7 @@ static void __exit apm_exit(void)
* (pm_idle), Wait for all processors to update cached/local
* copies of pm_idle before proceeding.
*/
- cpu_idle_wait();
+ kick_all_cpus_sync();
}
if (((apm_info.bios.flags & APM_BIOS_DISENGAGED) == 0)
&& (apm_info.connection_version > 0x0100)) {
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 8aa532f..8215458 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -525,26 +525,6 @@ void stop_this_cpu(void *dummy)
}
}
-static void do_nothing(void *unused)
-{
-}
-
-/*
- * cpu_idle_wait - Used to ensure that all the CPUs discard old value of
- * pm_idle and update to new pm_idle value. Required while changing pm_idle
- * handler on SMP systems.
- *
- * Caller must have changed pm_idle to the new value before the call. Old
- * pm_idle value will not be used by any CPU after the return of this function.
- */
-void cpu_idle_wait(void)
-{
- smp_mb();
- /* kick all the CPUs so that they exit out of pm_idle */
- smp_call_function(do_nothing, NULL, 1);
-}
-EXPORT_SYMBOL_GPL(cpu_idle_wait);
-
/* Default MONITOR/MWAIT with no hints, used for default C1 state */
static void mwait_idle(void)
{
next prev parent reply other threads:[~2012-05-08 12:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 17:59 [patch 0/8] cpuidle: Fix and replace cpu_idle_wait copied code Thomas Gleixner
2012-05-07 17:59 ` [patch 1/8] powerpc: Fix broken cpu_idle_wait() implementation Thomas Gleixner
2012-05-08 12:25 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 3/8] cpuidle: Use kick_all_cpus_sync() Thomas Gleixner
2012-05-08 12:26 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 2/8] smp: Implement kick_all_cpus_sync() Thomas Gleixner
2012-05-08 12:26 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 4/8] x86: Use kick_all_cpus_sync() Thomas Gleixner
2012-05-08 12:27 ` tip-bot for Thomas Gleixner [this message]
2012-05-07 17:59 ` [patch 5/8] arm: Remove unused cpu_idle_wait() Thomas Gleixner
2012-05-08 12:28 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 7/8] ia64: " Thomas Gleixner
2012-05-08 12:29 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 6/8] powerpc: " Thomas Gleixner
2012-05-08 12:30 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 8/8] sh: Remove cpu_idle_wait() Thomas Gleixner
2012-05-08 12:31 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 20:06 ` [patch 0/8] cpuidle: Fix and replace cpu_idle_wait copied code Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-85f7f656274fa0ba109dd8774db3887d42de5c6b@git.kernel.org \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox