From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, acme@redhat.com, dsahern@gmail.com,
tglx@linutronix.de, hpa@zytor.com, peterz@infradead.org,
namhyung@kernel.org, linux-kernel@vger.kernel.org,
jolsa@kernel.org
Subject: [tip:perf/core] perf tools: Use shell function for perl cflags retrieval
Date: Sat, 18 Nov 2017 00:26:21 -0800 [thread overview]
Message-ID: <tip-86f5fe01cf3ad42e99e7655dec93e0e36ef65614@git.kernel.org> (raw)
In-Reply-To: <20171108102739.30338-2-jolsa@kernel.org>
Commit-ID: 86f5fe01cf3ad42e99e7655dec93e0e36ef65614
Gitweb: https://git.kernel.org/tip/86f5fe01cf3ad42e99e7655dec93e0e36ef65614
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Wed, 8 Nov 2017 11:27:37 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 16 Nov 2017 14:49:52 -0300
perf tools: Use shell function for perl cflags retrieval
Using the shell function for perl CFLAGS retrieval instead of back
quotes (``). Both execute shell with the command, but the latter is more
explicit and seems to be the preferred way.
Also we don't have any other use of the back quotes in perf Makefiles.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20171108102739.30338-2-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile.config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 63f534a..f6786fa 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -579,7 +579,7 @@ else
PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null)
PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS))
PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS))
- PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null`
+ PERL_EMBED_CCOPTS = $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null)
FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS)
ifneq ($(feature-libperl), 1)
next prev parent reply other threads:[~2017-11-18 8:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 10:27 [PATCH 0/3] perf tools: Build fixes Jiri Olsa
2017-11-08 10:27 ` [PATCH 1/3] perf tools: Use shell function for perl cflags retrieval Jiri Olsa
2017-11-08 16:03 ` Arnaldo Carvalho de Melo
2017-11-18 8:26 ` tip-bot for Jiri Olsa [this message]
2017-12-18 17:15 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2017-11-08 10:27 ` [PATCH 2/3] perf tools: Fix build for hardened environments Jiri Olsa
2017-11-08 16:03 ` Arnaldo Carvalho de Melo
2017-11-09 7:36 ` Jiri Olsa
2017-11-09 12:52 ` Arnaldo Carvalho de Melo
2017-11-10 9:43 ` Jiri Olsa
2017-11-23 14:15 ` Arnaldo Carvalho de Melo
2017-11-23 14:38 ` Jiri Olsa
2017-11-29 19:54 ` Arnaldo Carvalho de Melo
2017-11-29 20:00 ` Arnaldo Carvalho de Melo
2017-11-30 10:08 ` Jiri Olsa
2017-12-01 2:11 ` Namhyung Kim
2017-12-04 7:34 ` Jiri Olsa
2017-12-04 8:24 ` Jiri Olsa
2017-12-04 15:35 ` Arnaldo Carvalho de Melo
2017-12-05 16:19 ` Jiri Olsa
2017-12-06 16:40 ` [tip:perf/core] perf tools: Fix up build in hardnened environments tip-bot for Jiri Olsa
2017-12-18 17:16 ` [tip:perf/urgent] perf tools: Fix up build in hardened environments tip-bot for Jiri Olsa
2017-11-08 10:27 ` [PATCH 3/3] perf tools: Removing FLAGS_PYTHON_EMBED/FLAGS_PERL_EMBED variables Jiri Olsa
2017-11-08 16:06 ` Arnaldo Carvalho de Melo
2017-11-09 7:27 ` Jiri Olsa
2017-11-09 12:48 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-86f5fe01cf3ad42e99e7655dec93e0e36ef65614@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).