From: tip-bot for Andy Lutomirski <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: bp@suse.de, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, hpa@zytor.com, mingo@kernel.org,
peterz@infradead.org, luto@kernel.org, dvlasenk@redhat.com,
tglx@linutronix.de, bp@alien8.de, brgerst@gmail.com
Subject: [tip:x86/asm] selftests/x86: Style fixes for the 'unwind_vdso' test
Date: Wed, 14 Oct 2015 08:29:22 -0700 [thread overview]
Message-ID: <tip-893a3ec27e1dae62a904f78d53244001979748a6@git.kernel.org> (raw)
In-Reply-To: <3335040bdd40d2bca4b1a28a3f8b165361c801b7.1444696194.git.luto@kernel.org>
Commit-ID: 893a3ec27e1dae62a904f78d53244001979748a6
Gitweb: http://git.kernel.org/tip/893a3ec27e1dae62a904f78d53244001979748a6
Author: Andy Lutomirski <luto@kernel.org>
AuthorDate: Mon, 12 Oct 2015 17:32:12 -0700
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 14 Oct 2015 16:56:28 +0200
selftests/x86: Style fixes for the 'unwind_vdso' test
Checkpatch is really quite bad for user code like this, but it
caught two legit style issues.
Reported-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/3335040bdd40d2bca4b1a28a3f8b165361c801b7.1444696194.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/testing/selftests/x86/unwind_vdso.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/x86/unwind_vdso.c b/tools/testing/selftests/x86/unwind_vdso.c
index 5992ff2..00a26a8 100644
--- a/tools/testing/selftests/x86/unwind_vdso.c
+++ b/tools/testing/selftests/x86/unwind_vdso.c
@@ -134,7 +134,7 @@ _Unwind_Reason_Code trace_fn(struct _Unwind_Context * ctx, void *opaque)
static void sigtrap(int sig, siginfo_t *info, void *ctx_void)
{
- ucontext_t *ctx = (ucontext_t*)ctx_void;
+ ucontext_t *ctx = (ucontext_t *)ctx_void;
struct unwind_state state;
unsigned long ip = ctx->uc_mcontext.gregs[REG_EIP];
@@ -192,7 +192,9 @@ int main()
* affected by libc/19006 (https://sourceware.org/PR19006).
*/
printf("[WARN]\tsyscall(2) didn't enter AT_SYSINFO\n");
- } if (get_eflags() & X86_EFLAGS_TF) {
+ }
+
+ if (get_eflags() & X86_EFLAGS_TF) {
printf("[FAIL]\tTF is still set\n");
nerrs++;
}
next prev parent reply other threads:[~2015-10-14 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 0:32 [PATCH 0/3] x86/entry: Fixlets after the big entry series Andy Lutomirski
2015-10-13 0:32 ` [PATCH 1/3] selftests/x86: Style fixes for unwind_vdso Andy Lutomirski
2015-10-14 15:29 ` tip-bot for Andy Lutomirski [this message]
2015-10-13 0:32 ` [PATCH 2/3] x86/asm: Remove the xyz_cfi macros from dwarf2.h Andy Lutomirski
2015-10-14 15:29 ` [tip:x86/asm] " tip-bot for Andy Lutomirski
2015-10-13 0:32 ` [PATCH 3/3] um: Fix build after x86 syscall changes Andy Lutomirski
2015-10-14 15:30 ` [tip:x86/asm] um/x86: " tip-bot for Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-893a3ec27e1dae62a904f78d53244001979748a6@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox