From: tip-bot for Stephane Eranian <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: alexander.shishkin@linux.intel.com, acme@redhat.com,
peterz@infradead.org, vincent.weaver@maine.edu,
torvalds@linux-foundation.org, kan.liang@intel.com,
jolsa@redhat.com, hpa@zytor.com, mingo@kernel.org,
linux-kernel@vger.kernel.org, eranian@google.com,
tglx@linutronix.de
Subject: [tip:perf/urgent] perf/x86/intel/uncore: Fix SKX CHA event extra regs
Date: Mon, 24 Jul 2017 03:18:34 -0700 [thread overview]
Message-ID: <tip-8aa7b7b4b4a601978672dce6604b9f5630b2eeb8@git.kernel.org> (raw)
In-Reply-To: <1499967350-10385-6-git-send-email-kan.liang@intel.com>
Commit-ID: 8aa7b7b4b4a601978672dce6604b9f5630b2eeb8
Gitweb: http://git.kernel.org/tip/8aa7b7b4b4a601978672dce6604b9f5630b2eeb8
Author: Stephane Eranian <eranian@google.com>
AuthorDate: Thu, 13 Jul 2017 10:35:49 -0700
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 24 Jul 2017 11:13:18 +0200
perf/x86/intel/uncore: Fix SKX CHA event extra regs
This patch adds two missing event extra regs for Skylake Server CHA PMU:
- TOR_INSERTS
- TOR_OCCUPANCY
Were missing support for all the filters, including opcode matchers.
Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Kan Liang <kan.liang@intel.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/1499967350-10385-6-git-send-email-kan.liang@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/events/intel/uncore_snbep.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
index 2401d06..f9f825b 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -3332,6 +3332,8 @@ static struct extra_reg skx_uncore_cha_extra_regs[] = {
SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4),
SNBEP_CBO_EVENT_EXTRA_REG(0x3134, 0xffff, 0x4),
SNBEP_CBO_EVENT_EXTRA_REG(0x9134, 0xffff, 0x4),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x35, 0xff, 0x8),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x36, 0xff, 0x8),
};
static u64 skx_cha_filter_mask(int fields)
@@ -3344,6 +3346,17 @@ static u64 skx_cha_filter_mask(int fields)
mask |= SKX_CHA_MSR_PMON_BOX_FILTER_LINK;
if (fields & 0x4)
mask |= SKX_CHA_MSR_PMON_BOX_FILTER_STATE;
+ if (fields & 0x8) {
+ mask |= SKX_CHA_MSR_PMON_BOX_FILTER_REM;
+ mask |= SKX_CHA_MSR_PMON_BOX_FILTER_LOC;
+ mask |= SKX_CHA_MSR_PMON_BOX_FILTER_ALL_OPC;
+ mask |= SKX_CHA_MSR_PMON_BOX_FILTER_NM;
+ mask |= SKX_CHA_MSR_PMON_BOX_FILTER_NOT_NM;
+ mask |= SKX_CHA_MSR_PMON_BOX_FILTER_OPC0;
+ mask |= SKX_CHA_MSR_PMON_BOX_FILTER_OPC1;
+ mask |= SKX_CHA_MSR_PMON_BOX_FILTER_NC;
+ mask |= SKX_CHA_MSR_PMON_BOX_FILTER_ISOC;
+ }
return mask;
}
next prev parent reply other threads:[~2017-07-24 10:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 17:35 [PATCH 0/6] several fixes for SKX uncore kan.liang
2017-07-13 17:35 ` [PATCH 1/6] perf/x86/uncore: fix Skylake UPI PMU event masks kan.liang
2017-07-24 10:16 ` [tip:perf/urgent] perf/x86/intel/uncore: Fix " tip-bot for Stephane Eranian
2017-07-13 17:35 ` [PATCH 2/6] perf/x86/uncore: fix Skylake server PCU PMU event format kan.liang
2017-07-24 10:17 ` [tip:perf/urgent] perf/x86/intel/uncore: Fix " tip-bot for Kan Liang
2017-07-13 17:35 ` [PATCH 3/6] perf/x86/uncore: fix Skylake server CHA LLC_LOOKUP event umask kan.liang
2017-07-24 10:17 ` [tip:perf/urgent] perf/x86/intel/uncore: Fix " tip-bot for Kan Liang
2017-07-13 17:35 ` [PATCH 4/6] perf/x86/uncore: remove invalid Skylake server CHA filter field kan.liang
2017-07-24 10:18 ` [tip:perf/urgent] perf/x86/intel/uncore: Remove " tip-bot for Kan Liang
2017-07-13 17:35 ` [PATCH 5/6] perf/x86/uncore: fix SKX CHA event extra regs kan.liang
2017-07-24 10:18 ` tip-bot for Stephane Eranian [this message]
2017-07-13 17:35 ` [PATCH 6/6] perf/x86/uncore: fix missing marker for skx_uncore_cha_extra_regs kan.liang
2017-07-24 10:18 ` [tip:perf/urgent] perf/x86/intel/uncore: Fix " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-8aa7b7b4b4a601978672dce6604b9f5630b2eeb8@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox