public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Nikhil P Rao <nikhil.rao@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	nikhil.rao@intel.com, suresh.b.siddha@intel.com,
	tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/urgent] x86: Remove unnecessary check in detect_ht()
Date: Wed, 25 May 2011 21:34:51 GMT	[thread overview]
Message-ID: <tip-8b27f2ff7a24f0735c96055e676872f05398d99b@git.kernel.org> (raw)
In-Reply-To: <1306343921.19325.1.camel@fedora13>

Commit-ID:  8b27f2ff7a24f0735c96055e676872f05398d99b
Gitweb:     http://git.kernel.org/tip/8b27f2ff7a24f0735c96055e676872f05398d99b
Author:     Nikhil P Rao <nikhil.rao@intel.com>
AuthorDate: Wed, 25 May 2011 10:18:41 -0700
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 25 May 2011 23:01:08 +0200

x86: Remove unnecessary check in detect_ht()

This patch removes a check that causes incorrect scheduler
domain setup (SMP instead of SMT) and bootlog warning messages
when cpuid extensions for topology enumeration are not supported
and the number of processors reported to the OS is smaller than
smp_num_siblings.

Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Nikhil P Rao <nikhil.rao@intel.com>
Link: http://lkml.kernel.org/r/1306343921.19325.1.camel@fedora13
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/cpu/common.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index c8b4162..53f02f5 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -477,13 +477,6 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c)
 	if (smp_num_siblings <= 1)
 		goto out;
 
-	if (smp_num_siblings > nr_cpu_ids) {
-		pr_warning("CPU: Unsupported number of siblings %d",
-			   smp_num_siblings);
-		smp_num_siblings = 1;
-		return;
-	}
-
 	index_msb = get_count_order(smp_num_siblings);
 	c->phys_proc_id = apic->phys_pkg_id(c->initial_apicid, index_msb);
 

      reply	other threads:[~2011-05-25 21:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <43F901BD926A4E43B106BF17856F0755018E1CF482@orsmsx508.amr.corp.intel.com>
     [not found] ` <4FF5AC937153B0459463C1A88EB478F2010DFD3D3F@orsmsx505.amr.corp.intel.com>
     [not found]   ` <43F901BD926A4E43B106BF17856F0755018E1CF69D@orsmsx508.amr.corp.intel.com>
     [not found]     ` <1305048201.2736.17.camel@sbsiddha-MOBL3.sc.intel.com>
     [not found]       ` <1F668163772FA946975B9466A9DFF729B5E5@ORSMSX101.amr.corp.intel.com>
2011-05-18 21:01         ` [PATCH] x86: Removing unnecessary check in detect_ht Rao, Nikhil
2011-05-18 21:07           ` Ingo Molnar
2011-05-18 21:13             ` Rao, Nikhil
2011-05-18 21:23               ` Ingo Molnar
2011-05-19  2:40                 ` Rao, Nikhil
2011-05-19 18:09                   ` Ingo Molnar
2011-05-19 23:03                     ` Rao, Nikhil
2011-05-20 11:46                       ` Ingo Molnar
2011-05-25 17:18                         ` Nikhil P Rao
2011-05-25 21:34                           ` tip-bot for Nikhil P Rao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-8b27f2ff7a24f0735c96055e676872f05398d99b@git.kernel.org \
    --to=nikhil.rao@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox