public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stoyan Gaydarov <stoyboyker@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	stoyboyker@gmail.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/debug] x86: BUG to BUG_ON changes
Date: Tue, 10 Mar 2009 08:57:31 GMT	[thread overview]
Message-ID: <tip-8c5dfd25519bf302ba43daa59976c4d675a594a7@git.kernel.org> (raw)
In-Reply-To: <1236661850-8237-8-git-send-email-stoyboyker@gmail.com>

Commit-ID:  8c5dfd25519bf302ba43daa59976c4d675a594a7
Gitweb:     http://git.kernel.org/tip/8c5dfd25519bf302ba43daa59976c4d675a594a7
Author:     "Stoyan Gaydarov" <stoyboyker@gmail.com>
AuthorDate: Tue, 10 Mar 2009 00:10:32 -0500
Commit:     Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 10 Mar 2009 09:55:18 +0100

x86: BUG to BUG_ON changes

Impact: cleanup

Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
LKML-Reference: <1236661850-8237-8-git-send-email-stoyboyker@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 arch/x86/kernel/cpu/common.c |    6 ++----
 arch/x86/kernel/quirks.c     |    3 +--
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 826d5c8..f886997 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -1078,8 +1078,7 @@ void __cpuinit cpu_init(void)
 
 	atomic_inc(&init_mm.mm_count);
 	me->active_mm = &init_mm;
-	if (me->mm)
-		BUG();
+	BUG_ON(me->mm);
 	enter_lazy_tlb(&init_mm, me);
 
 	load_sp0(t, &current->thread);
@@ -1145,8 +1144,7 @@ void __cpuinit cpu_init(void)
 	 */
 	atomic_inc(&init_mm.mm_count);
 	curr->active_mm = &init_mm;
-	if (curr->mm)
-		BUG();
+	BUG_ON(curr->mm);
 	enter_lazy_tlb(&init_mm, curr);
 
 	load_sp0(t, thread);
diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
index 309949e..6a5a297 100644
--- a/arch/x86/kernel/quirks.c
+++ b/arch/x86/kernel/quirks.c
@@ -74,8 +74,7 @@ static void ich_force_hpet_resume(void)
 	if (!force_hpet_address)
 		return;
 
-	if (rcba_base == NULL)
-		BUG();
+	BUG_ON(rcba_base == NULL);
 
 	/* read the Function Disable register, dword mode only */
 	val = readl(rcba_base + 0x3404);

  parent reply	other threads:[~2009-03-10  8:58 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-10  5:10 [PATCH 00/25] BUG to BUG_ON changes Stoyan Gaydarov
2009-03-10  5:10 ` [PATCH 01/25] [btrfs] " Stoyan Gaydarov
2009-03-10  5:10   ` [PATCH 02/25] [staging] " Stoyan Gaydarov
2009-03-10  5:10     ` [PATCH 03/25] [net] " Stoyan Gaydarov
2009-03-10  5:10       ` [PATCH 04/25] [arm] " Stoyan Gaydarov
2009-03-10  5:10         ` [PATCH 05/25] [ia64] " Stoyan Gaydarov
2009-03-10  5:10           ` [PATCH 06/25] [mips] " Stoyan Gaydarov
2009-03-10  5:10             ` [PATCH 07/25] [x86] " Stoyan Gaydarov
2009-03-10  5:10               ` [PATCH 08/25] [sparc] " Stoyan Gaydarov
2009-03-10  5:10                 ` [PATCH 09/25] [s390] " Stoyan Gaydarov
2009-03-10  5:10                   ` [PATCH 10/25] [mn10300] " Stoyan Gaydarov
2009-03-10  5:10                     ` [PATCH 11/25] [alpha] " Stoyan Gaydarov
2009-03-10  5:10                       ` [PATCH 12/25] [frv] " Stoyan Gaydarov
2009-03-10  5:10                         ` [PATCH 13/25] [blackfin] " Stoyan Gaydarov
2009-03-10  5:10                           ` [PATCH 14/25] [mm] " Stoyan Gaydarov
2009-03-10  5:10                             ` [PATCH 15/25] [cris] " Stoyan Gaydarov
2009-03-10  5:10                               ` [PATCH 16/25] [m32r] " Stoyan Gaydarov
2009-03-10  5:10                                 ` [PATCH 17/25] [parisc] " Stoyan Gaydarov
2009-03-10  5:10                                   ` [PATCH 18/25] [xtensa] " Stoyan Gaydarov
2009-03-10  5:10                                     ` [PATCH 19/25] [sysctl.c] " Stoyan Gaydarov
2009-03-10  5:10                                       ` [PATCH 20/25] [scsi] " Stoyan Gaydarov
2009-03-10  5:10                                         ` [PATCH 21/25] [afs] " Stoyan Gaydarov
2009-03-10  5:10                                           ` [PATCH 22/25] [reiserfs] " Stoyan Gaydarov
2009-03-10  5:10                                             ` [PATCH 23/25] [drivers/misc] " Stoyan Gaydarov
2009-03-10  5:10                                               ` [PATCH 24/25] [crypto] " Stoyan Gaydarov
2009-03-10  5:10                                                 ` [PATCH 25/25] [drivers] " Stoyan Gaydarov
2009-03-11 11:54                                           ` [PATCH 21/25] [afs] " David Howells
2009-03-13  4:51                                   ` [PATCH 17/25] [parisc] " Kyle McMartin
2009-03-10  7:49                                 ` [PATCH 16/25] [m32r] " Hirokazu Takata
2009-04-02 11:57                               ` [PATCH 15/25] [cris] " Jesper Nilsson
2009-03-11 11:48                         ` [PATCH 12/25] [frv] " David Howells
2009-03-11 11:36                     ` [PATCH 10/25] [mn10300] " David Howells
2009-03-10 11:17                   ` [PATCH 09/25] [s390] " Christian Borntraeger
2009-03-10  5:16                 ` [PATCH 08/25] [sparc] " David Miller
2009-03-10  8:37               ` [PATCH 07/25] [x86] " Ingo Molnar
2009-03-10  8:57               ` Stoyan Gaydarov [this message]
2009-03-11 19:18             ` [PATCH 06/25] [mips] " Ralf Baechle
2009-03-10  5:16       ` [PATCH 03/25] [net] " David Miller
2009-03-10 10:23       ` Alexey Dobriyan
2009-03-10 11:24         ` David Miller
2009-03-10 19:54       ` Brandeburg, Jesse
2009-03-10 10:22     ` [PATCH 02/25] [staging] " Alexey Dobriyan
2009-03-10  9:16   ` [PATCH 01/25] [btrfs] " David John
2009-03-10 18:16     ` Stoyan Gaydarov
2009-03-10 18:20       ` Oliver Mattos
2009-03-10 13:24   ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-8c5dfd25519bf302ba43daa59976c4d675a594a7@git.kernel.org \
    --to=stoyboyker@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox