From: tip-bot for Borislav Petkov <bp@amd64.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
jkacur@redhat.com, rostedt@goodmis.org, tglx@linutronix.de,
bp@amd64.org, borislav.petkov@amd.com
Subject: [tip:perf/core] ftrace: Remove a superfluous check
Date: Wed, 20 Jun 2012 03:38:32 -0700 [thread overview]
Message-ID: <tip-8d240dd88cca33b704adf3fe281aa64b5aac2dd8@git.kernel.org> (raw)
In-Reply-To: <20120329171140.GE6409@aftab>
Commit-ID: 8d240dd88cca33b704adf3fe281aa64b5aac2dd8
Gitweb: http://git.kernel.org/tip/8d240dd88cca33b704adf3fe281aa64b5aac2dd8
Author: Borislav Petkov <bp@amd64.org>
AuthorDate: Thu, 29 Mar 2012 19:11:40 +0200
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Thu, 14 Jun 2012 15:22:12 -0400
ftrace: Remove a superfluous check
register_ftrace_function() checks ftrace_disabled and calls
__register_ftrace_function which does it again.
Drop the first check and add the unlikely hint to the second one. Also,
drop the label as John correctly notices.
No functional change.
Link: http://lkml.kernel.org/r/20120329171140.GE6409@aftab
Cc: Borislav Petkov <bp@amd64.org>
Cc: John Kacur <jkacur@redhat.com>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/ftrace.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index a008663..b4f20fb 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -312,7 +312,7 @@ static int remove_ftrace_list_ops(struct ftrace_ops **list,
static int __register_ftrace_function(struct ftrace_ops *ops)
{
- if (ftrace_disabled)
+ if (unlikely(ftrace_disabled))
return -ENODEV;
if (FTRACE_WARN_ON(ops == &global_ops))
@@ -4299,16 +4299,12 @@ int register_ftrace_function(struct ftrace_ops *ops)
mutex_lock(&ftrace_lock);
- if (unlikely(ftrace_disabled))
- goto out_unlock;
-
ret = __register_ftrace_function(ops);
if (!ret)
ret = ftrace_startup(ops, 0);
-
- out_unlock:
mutex_unlock(&ftrace_lock);
+
return ret;
}
EXPORT_SYMBOL_GPL(register_ftrace_function);
next prev parent reply other threads:[~2012-06-20 10:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 16:44 [PATCH] ftrace: Remove a superfluous check Borislav Petkov
2012-03-29 17:03 ` John Kacur
2012-03-29 17:11 ` Borislav Petkov
2012-03-29 17:17 ` John Kacur
2012-03-29 17:23 ` Steven Rostedt
2012-03-29 17:26 ` Borislav Petkov
2012-05-24 16:32 ` Borislav Petkov
2012-05-24 16:41 ` Steven Rostedt
2012-05-24 17:04 ` Borislav Petkov
2012-06-20 10:38 ` tip-bot for Borislav Petkov [this message]
2012-03-29 17:14 ` Steven Rostedt
2012-03-29 17:27 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-8d240dd88cca33b704adf3fe281aa64b5aac2dd8@git.kernel.org \
--to=bp@amd64.org \
--cc=borislav.petkov@amd.com \
--cc=hpa@zytor.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox