From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932113AbbLJIQY (ORCPT ); Thu, 10 Dec 2015 03:16:24 -0500 Received: from terminus.zytor.com ([198.137.202.10]:55080 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755313AbbLJIQU (ORCPT ); Thu, 10 Dec 2015 03:16:20 -0500 Date: Thu, 10 Dec 2015 00:15:41 -0800 From: tip-bot for Ingo Molnar Message-ID: Cc: dcb314@hotmail.com, tglx@linutronix.de, acme@redhat.com, a.p.zijlstra@chello.nl, hpa@zytor.com, mingo@kernel.org, bp@alien8.de, linux-kernel@vger.kernel.org, jolsa@redhat.com Reply-To: acme@redhat.com, dcb314@hotmail.com, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, a.p.zijlstra@chello.nl, bp@alien8.de, linux-kernel@vger.kernel.org, jolsa@redhat.com In-Reply-To: <20150305103213.GA23046@gmail.com> References: <20150305103213.GA23046@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tui: Change default selection background color to yellow Git-Commit-ID: 8d7d377c2bea16afa6b600a4517615a9eebb259b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 8d7d377c2bea16afa6b600a4517615a9eebb259b Gitweb: http://git.kernel.org/tip/8d7d377c2bea16afa6b600a4517615a9eebb259b Author: Ingo Molnar AuthorDate: Thu, 5 Mar 2015 11:32:13 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 9 Dec 2015 13:41:55 -0300 perf tui: Change default selection background color to yellow Boris reported that 'perf top' is unusable on his default 'black on white' terminal, which uses (eye friendly) light-grey as a background color. The reason is that the TUI cursor for the current selection line uses HE_COLORSET_SELECTED, and that has a default background color of 'lightgrey' - which is a common terminal background choice and thus the colors conflict. Use yellow as the background color instead: that should be an uncommon terminal background, yet it's still ergonomic on both black and white/grey terminals. [ It would be a better solution to straight out detect color collisions and resolve them reasonably by converting them to RGB and calculating color space distances, but I was unable to find proper documentation for SLtt_get_color_object() to recover the current color scheme so I gave up ... Yellow works well enough. ] Reported-and-Tested-by: Borislav Petkov Signed-off-by: Ingo Molnar Tested-by: Arnaldo Carvalho de Melo Cc: David Binderman Cc: Jiri Olsa Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20150305103213.GA23046@gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c index e9703c0..d372021 100644 --- a/tools/perf/ui/browser.c +++ b/tools/perf/ui/browser.c @@ -528,7 +528,7 @@ static struct ui_browser_colorset { .colorset = HE_COLORSET_SELECTED, .name = "selected", .fg = "black", - .bg = "lightgray", + .bg = "yellow", }, { .colorset = HE_COLORSET_CODE,