From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753483AbcD0Pdp (ORCPT ); Wed, 27 Apr 2016 11:33:45 -0400 Received: from terminus.zytor.com ([198.137.202.10]:50964 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbcD0Pdn (ORCPT ); Wed, 27 Apr 2016 11:33:43 -0400 Date: Wed, 27 Apr 2016 08:32:50 -0700 From: tip-bot for Colin Ian King Message-ID: Cc: alexander.shishkin@linux.intel.com, mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, jolsa@kernel.org, peterz@infradead.org, colin.king@canonical.com, acme@redhat.com, mhiramat@kernel.org Reply-To: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, jolsa@kernel.org, acme@redhat.com, colin.king@canonical.com, mhiramat@kernel.org, alexander.shishkin@linux.intel.com, mingo@kernel.org, hpa@zytor.com In-Reply-To: <1461419154-16918-1-git-send-email-colin.king@canonical.com> References: <1461419154-16918-1-git-send-email-colin.king@canonical.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tests: Replace assignment with comparison on assert check Git-Commit-ID: 8daef508b0a144970e5cbc587525c351663fec63 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 8daef508b0a144970e5cbc587525c351663fec63 Gitweb: http://git.kernel.org/tip/8daef508b0a144970e5cbc587525c351663fec63 Author: Colin Ian King AuthorDate: Sat, 23 Apr 2016 14:45:54 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Apr 2016 20:24:26 -0300 perf tests: Replace assignment with comparison on assert check The current assert check is checking an assignment, which will always be true. Instead, the assert should be checking if scale is equal to 0.122 Signed-off-by: Colin Ian King Reviewed-by: Masami Hiramatsu Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1461419154-16918-1-git-send-email-colin.king@canonical.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/event_update.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c index 012eab5..63ecf21 100644 --- a/tools/perf/tests/event_update.c +++ b/tools/perf/tests/event_update.c @@ -30,7 +30,7 @@ static int process_event_scale(struct perf_tool *tool __maybe_unused, TEST_ASSERT_VAL("wrong id", ev->id == 123); TEST_ASSERT_VAL("wrong id", ev->type == PERF_EVENT_UPDATE__SCALE); - TEST_ASSERT_VAL("wrong scale", ev_data->scale = 0.123); + TEST_ASSERT_VAL("wrong scale", ev_data->scale == 0.123); return 0; }