From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752132AbdKHK5W (ORCPT ); Wed, 8 Nov 2017 05:57:22 -0500 Received: from terminus.zytor.com ([65.50.211.136]:46349 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbdKHK5V (ORCPT ); Wed, 8 Nov 2017 05:57:21 -0500 Date: Wed, 8 Nov 2017 02:52:49 -0800 From: tip-bot for Frederic Weisbecker Message-ID: Cc: tj@kernel.org, frederic@kernel.org, hpa@zytor.com, mingo@kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, jiangshanlai@gmail.com, tglx@linutronix.de, peterz@infradead.org, paulmck@linux.vnet.ibm.com Reply-To: frederic@kernel.org, hpa@zytor.com, tj@kernel.org, peterz@infradead.org, paulmck@linux.vnet.ibm.com, mingo@kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, jiangshanlai@gmail.com, tglx@linutronix.de In-Reply-To: <1509980490-4285-4-git-send-email-frederic@kernel.org> References: <1509980490-4285-4-git-send-email-frederic@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/core] workqueue: Use lockdep to assert IRQs are disabled/enabled Git-Commit-ID: 8e8eb730759f9cfd7a761b0b4ee41d714e720993 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 8e8eb730759f9cfd7a761b0b4ee41d714e720993 Gitweb: https://git.kernel.org/tip/8e8eb730759f9cfd7a761b0b4ee41d714e720993 Author: Frederic Weisbecker AuthorDate: Mon, 6 Nov 2017 16:01:19 +0100 Committer: Ingo Molnar CommitDate: Wed, 8 Nov 2017 11:13:48 +0100 workqueue: Use lockdep to assert IRQs are disabled/enabled Use lockdep to check that IRQs are enabled or disabled as expected. This way the sanity check only shows overhead when concurrency correctness debug code is enabled. Signed-off-by: Frederic Weisbecker Acked-by: Thomas Gleixner Acked-by: Tejun Heo Cc: David S . Miller Cc: Lai Jiangshan Cc: Linus Torvalds Cc: Paul E. McKenney Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1509980490-4285-4-git-send-email-frederic@kernel.org Signed-off-by: Ingo Molnar --- kernel/workqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 1070b21..13f67b5 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1376,7 +1376,7 @@ static void __queue_work(int cpu, struct workqueue_struct *wq, * queued or lose PENDING. Grabbing PENDING and queueing should * happen with IRQ disabled. */ - WARN_ON_ONCE(!irqs_disabled()); + lockdep_assert_irqs_disabled(); debug_work_activate(work);