linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Frederic Weisbecker <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, eranian@google.com,
	acme@redhat.com, hpa@zytor.com, mingo@kernel.org,
	anish198519851985@gmail.com, peterz@infradead.org,
	srivatsa.bhat@linux.vnet.ibm.com, namhyung@kernel.org,
	jolsa@redhat.com, fweisbec@gmail.com, tglx@linutronix.de,
	dzickus@redhat.com
Subject: [tip:perf/core] watchdog: Make it work under full dynticks
Date: Wed, 31 Jul 2013 01:57:07 -0700	[thread overview]
Message-ID: <tip-93786a5f6aeb9c032c1c240246c5aabcf457b38f@git.kernel.org> (raw)
In-Reply-To: <1374539466-4799-9-git-send-email-fweisbec@gmail.com>

Commit-ID:  93786a5f6aeb9c032c1c240246c5aabcf457b38f
Gitweb:     http://git.kernel.org/tip/93786a5f6aeb9c032c1c240246c5aabcf457b38f
Author:     Frederic Weisbecker <fweisbec@gmail.com>
AuthorDate: Tue, 23 Jul 2013 02:31:06 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 30 Jul 2013 22:29:15 +0200

watchdog: Make it work under full dynticks

A perf event can be used without forcing the tick to
stay alive if it doesn't use a frequency but a sample
period and if it doesn't throttle (raise storm of events).

Since the lockup detector neither use a perf event frequency
nor should ever throttle due to its high period, it can now
run concurrently with the full dynticks feature.

So remove the hack that disabled the watchdog.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Anish Singh <anish198519851985@gmail.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1374539466-4799-9-git-send-email-fweisbec@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/watchdog.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 1241d8c..51c4f34 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -553,14 +553,6 @@ void __init lockup_detector_init(void)
 {
 	set_sample_period();
 
-#ifdef CONFIG_NO_HZ_FULL
-	if (watchdog_user_enabled) {
-		watchdog_user_enabled = 0;
-		pr_warning("Disabled lockup detectors by default for full dynticks\n");
-		pr_warning("You can reactivate it with 'sysctl -w kernel.watchdog=1'\n");
-	}
-#endif
-
 	if (watchdog_user_enabled)
 		watchdog_enable_all_cpus();
 }

  parent reply	other threads:[~2013-07-31  8:57 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  0:30 [PATCH 0/8] perf: Finer grained full dynticks handling Frederic Weisbecker
2013-07-23  0:30 ` [PATCH 1/8] perf: Fix branch stack refcount leak on callchain init failure Frederic Weisbecker
2013-07-31  8:55   ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 2/8] perf: Sanitize get_callchain_buffer() Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-08-01 13:01   ` [PATCH 2/8] " Jiri Olsa
2013-08-01 13:28     ` Frederic Weisbecker
2013-08-01 13:32       ` Jiri Olsa
2013-08-01 13:49         ` Frederic Weisbecker
2013-08-01 13:54           ` Jiri Olsa
2013-08-01 13:57             ` Frederic Weisbecker
2013-08-01 13:29   ` Jiri Olsa
2013-08-01 13:42     ` Frederic Weisbecker
2013-08-01 13:51       ` Jiri Olsa
2013-08-01 14:30         ` Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 3/8] perf: Gather event accounting code Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] perf: Factor out event accounting code to account_event()/__free_event() tip-bot for Frederic Weisbecker
2013-08-01 13:13   ` [PATCH 3/8] perf: Gather event accounting code Jiri Olsa
2013-08-01 13:30     ` Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 4/8] perf: Split per cpu " Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] perf: Split the per-cpu accounting part of the " tip-bot for Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 5/8] perf: Migrate per cpu event accounting Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 6/8] perf: Account freq events per cpu Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-08-01 12:46   ` [PATCH 6/8] " Jiri Olsa
2013-08-01 12:48     ` Jiri Olsa
2013-08-01 13:31     ` Peter Zijlstra
2013-08-01 13:35       ` Peter Zijlstra
2013-08-01 13:39       ` Jiri Olsa
2013-08-01 13:56         ` Peter Zijlstra
2013-08-01 13:55       ` Frederic Weisbecker
2013-08-01 14:03         ` Peter Zijlstra
2013-08-01 14:06           ` Peter Zijlstra
2013-08-01 14:21             ` Frederic Weisbecker
2013-08-01 14:40               ` Peter Zijlstra
2013-08-02 16:25                 ` Frederic Weisbecker
2013-08-01 14:19           ` Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 7/8] perf: Finer grained full dynticks kick Frederic Weisbecker
2013-07-31  8:56   ` [tip:perf/core] perf: Implement finer " tip-bot for Frederic Weisbecker
2013-07-23  0:31 ` [PATCH 8/8] watchdog: Remove hack to make full dynticks working Frederic Weisbecker
2013-07-23 12:33   ` Don Zickus
2013-07-23 12:44     ` Frederic Weisbecker
2013-07-23 12:45     ` Peter Zijlstra
2013-07-31  8:57   ` tip-bot for Frederic Weisbecker [this message]
2013-07-25  9:59 ` [PATCH 0/8] perf: Finer grained full dynticks handling Peter Zijlstra
2013-07-25 14:02   ` Frederic Weisbecker
2013-07-25 16:29     ` Peter Zijlstra
2013-07-25 20:07       ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-93786a5f6aeb9c032c1c240246c5aabcf457b38f@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=anish198519851985@gmail.com \
    --cc=dzickus@redhat.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).