Re: [PATCH 11/16] perf util: Parse header_page to get proper long size

Jiri Olsa
2013-06-07T09:02:11Z

On Fri, Jun 07, 2013 at 05:56:08PM +0900, Namhyung Kim wrote:
> Hi Jiri,
>
> On Thu, 6 Jun 2013 17:37:37 +0200, Jiri Olsa wrote:
> > On Tue, Jun 04, 2013 at 02:20:26PM +0900, Namhyung Kim wrote:
> >> From: Namhyung Kim <namhyung.kim@lge.com>
> >>
> >> The header_page file describes the format of the ring buffer page
> >> which is used by ftrace (not perf). And size of "commit" field (I
> >> guess it's older name was 'size') represents the real size of long
> >> type used for kernel. So update the pevent's long size.
> >>
> > any reason why not merge this one with
> > 83ae6eb perf util: Skip reading header_event file
>
> Just try to keep it doing one thing in a patch. But if you think it'd
> better merging it, I'll do it. :)

nope, just curious if I missed something ;-) it's ok

jirka