From: tip-bot for Dan Carpenter <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, mojha@codeaurora.org, jason@lakedaemon.net,
marc.zyngier@arm.com, dan.carpenter@oracle.com, hpa@zytor.com,
mingo@kernel.org, jiaxun.yang@flygoat.com,
linux-kernel@vger.kernel.org
Subject: [tip:irq/urgent] irqchip/irq-ls1x: Missing error code in ls1x_intc_of_init()
Date: Fri, 5 Apr 2019 05:43:11 -0700 [thread overview]
Message-ID: <tip-95c5c618fa4349b2ba13aebeabf71911208dfc5e@git.kernel.org> (raw)
In-Reply-To: <20190329062136.GQ32613@kadam>
Commit-ID: 95c5c618fa4349b2ba13aebeabf71911208dfc5e
Gitweb: https://git.kernel.org/tip/95c5c618fa4349b2ba13aebeabf71911208dfc5e
Author: Dan Carpenter <dan.carpenter@oracle.com>
AuthorDate: Fri, 29 Mar 2019 09:21:37 +0300
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 5 Apr 2019 14:37:56 +0200
irqchip/irq-ls1x: Missing error code in ls1x_intc_of_init()
Currently, when irq_domain_add_linear() fails, the error code does not get
set so it returns zero which is wrong. Fix it by setting the appropriate
error code.
Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: kernel-janitors@vger.kernel.org
Link: https://lkml.kernel.org/r/20190329062136.GQ32613@kadam
---
drivers/irqchip/irq-ls1x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-ls1x.c b/drivers/irqchip/irq-ls1x.c
index 86b72fbd3b45..353111a10413 100644
--- a/drivers/irqchip/irq-ls1x.c
+++ b/drivers/irqchip/irq-ls1x.c
@@ -130,6 +130,7 @@ static int __init ls1x_intc_of_init(struct device_node *node,
NULL);
if (!priv->domain) {
pr_err("ls1x-irq: cannot add IRQ domain\n");
+ err = -ENOMEM;
goto out_iounmap;
}
prev parent reply other threads:[~2019-04-05 12:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 14:38 [PATCH] irqchip/irq-ls1x: Missing error code in ls1x_intc_of_init() Dan Carpenter
2019-03-28 19:14 ` Mukesh Ojha
2019-03-29 6:21 ` [PATCH v2] " Dan Carpenter
2019-03-31 4:03 ` Jiaxun Yang
2019-04-05 12:43 ` tip-bot for Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-95c5c618fa4349b2ba13aebeabf71911208dfc5e@git.kernel.org \
--to=tipbot@zytor.com \
--cc=dan.carpenter@oracle.com \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@kernel.org \
--cc=mojha@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox