public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Milian Wolff <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, milian.wolff@kdab.com, yao.jin@linux.intel.com,
	acme@redhat.com, mingo@kernel.org, jolsa@redhat.com,
	linux-kernel@vger.kernel.org, peterz@infradead.org,
	tglx@linutronix.de, namhyung@kernel.org, dsahern@gmail.com
Subject: [tip:perf/core] perf script: Mark inlined frames and do not print DSO for them
Date: Wed, 25 Oct 2017 10:18:50 -0700	[thread overview]
Message-ID: <tip-9628b56dc1240ce0faa3bd9b7a3390fa4451c59f@git.kernel.org> (raw)
In-Reply-To: <20171009203310.17362-9-milian.wolff@kdab.com>

Commit-ID:  9628b56dc1240ce0faa3bd9b7a3390fa4451c59f
Gitweb:     https://git.kernel.org/tip/9628b56dc1240ce0faa3bd9b7a3390fa4451c59f
Author:     Milian Wolff <milian.wolff@kdab.com>
AuthorDate: Mon, 9 Oct 2017 22:33:02 +0200
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 24 Oct 2017 09:59:56 -0300

perf script: Mark inlined frames and do not print DSO for them

Instead of showing the (repeated) DSO name of the non-inlined frame, we
now show the "(inlined)" suffix instead.

Before:
                   214f7 __hypot_finite (/usr/lib/libm-2.25.so)
                    ace3 hypot (/usr/lib/libm-2.25.so)
                     a4a std::__complex_abs (/home/milian/projects/src/perf-tests/inlining)
                     a4a std::abs<double> (/home/milian/projects/src/perf-tests/inlining)
                     a4a std::_Norm_helper<true>::_S_do_it<double> (/home/milian/projects/src/perf-tests/inlining)
                     a4a std::norm<double> (/home/milian/projects/src/perf-tests/inlining)
                     a4a main (/home/milian/projects/src/perf-tests/inlining)
                   20510 __libc_start_main (/usr/lib/libc-2.25.so)
                     bd9 _start (/home/milian/projects/src/perf-tests/inlining)

After:
                   214f7 __hypot_finite (/usr/lib/libm-2.25.so)
                    ace3 hypot (/usr/lib/libm-2.25.so)
                     a4a std::__complex_abs (inlined)
                     a4a std::abs<double> (inlined)
                     a4a std::_Norm_helper<true>::_S_do_it<double> (inlined)
                     a4a std::norm<double> (inlined)
                     a4a main (/home/milian/projects/src/perf-tests/inlining)
                   20510 __libc_start_main (/usr/lib/libc-2.25.so)
                     bd9 _start (/home/milian/projects/src/perf-tests/inlining)

Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
Reviewed-by: Jiri Olsa <jolsa@redhat.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Yao Jin <yao.jin@linux.intel.com>
Link: http://lkml.kernel.org/r/20171009203310.17362-9-milian.wolff@kdab.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/evsel_fprintf.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c
index f2c6c5e..5b9e892 100644
--- a/tools/perf/util/evsel_fprintf.c
+++ b/tools/perf/util/evsel_fprintf.c
@@ -157,7 +157,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,
 				}
 			}
 
-			if (print_dso) {
+			if (print_dso && (!node->sym || !node->sym->inlined)) {
 				printed += fprintf(fp, " (");
 				printed += map__fprintf_dsoname(node->map, fp);
 				printed += fprintf(fp, ")");
@@ -166,6 +166,9 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,
 			if (print_srcline)
 				printed += map__fprintf_srcline(node->map, addr, "\n  ", fp);
 
+			if (node->sym && node->sym->inlined)
+				printed += fprintf(fp, " (inlined)");
+
 			if (!print_oneline)
 				printed += fprintf(fp, "\n");
 

  reply	other threads:[~2017-10-25 17:22 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09 20:32 [PATCH v5 00/16] generate full callchain cursor entries for inlined frames Milian Wolff
2017-10-09 20:32 ` [PATCH v5 01/16] perf report: remove code to handle inline frames from browsers Milian Wolff
2017-10-25 17:15   ` [tip:perf/core] perf report: Remove " tip-bot for Milian Wolff
2017-10-09 20:32 ` [PATCH v5 02/16] perf util: store srcline in callchain_cursor_node Milian Wolff
2017-10-25 17:16   ` [tip:perf/core] perf callchain: Store " tip-bot for Milian Wolff
2017-10-09 20:32 ` [PATCH v5 03/16] perf util: refactor inline_list to operate on symbols Milian Wolff
2017-10-25 17:16   ` [tip:perf/core] perf callchain: Refactor " tip-bot for Milian Wolff
2017-10-09 20:32 ` [PATCH v5 04/16] perf util: refactor inline_list to store srcline string directly Milian Wolff
2017-10-25 17:17   ` [tip:perf/core] perf callchain: Refactor " tip-bot for Milian Wolff
2017-10-09 20:32 ` [PATCH v5 05/16] perf report: create real callchain entries for inlined frames Milian Wolff
2017-10-25 17:17   ` [tip:perf/core] perf callchain: Create " tip-bot for Milian Wolff
2017-10-09 20:33 ` [PATCH v5 06/16] perf report: fall-back to function name comparison for -g srcline Milian Wolff
2017-10-25 17:18   ` [tip:perf/core] perf report: Fall-back " tip-bot for Milian Wolff
2017-10-09 20:33 ` [PATCH v5 07/16] perf report: mark inlined frames in output by " (inlined)" suffix Milian Wolff
2017-10-25 17:18   ` [tip:perf/core] perf callchain: Mark " tip-bot for Milian Wolff
2017-10-09 20:33 ` [PATCH v5 08/16] perf script: mark inlined frames and do not print DSO for them Milian Wolff
2017-10-25 17:18   ` tip-bot for Milian Wolff [this message]
2017-10-09 20:33 ` [PATCH v5 09/16] perf report: compare symbol name for inlined frames when matching Milian Wolff
2017-10-13 13:28   ` Arnaldo Carvalho de Melo
2017-10-25 17:19   ` [tip:perf/core] perf callchain: Compare " tip-bot for Milian Wolff
2017-10-09 20:33 ` [PATCH v5 10/16] perf report: compare symbol name for inlined frames when sorting Milian Wolff
2017-10-25 17:19   ` [tip:perf/core] perf report: Compare " tip-bot for Milian Wolff
2017-10-09 20:33 ` [PATCH v5 11/16] perf report: properly handle branch count in match_chain Milian Wolff
2017-10-13 13:39   ` Arnaldo Carvalho de Melo
2017-10-13 14:08     ` Arnaldo Carvalho de Melo
2017-10-14 19:30       ` Milian Wolff
2017-10-16 14:17         ` Arnaldo Carvalho de Melo
2017-10-16  4:18       ` ravi
2017-10-16  8:27         ` Milian Wolff
2017-10-16 14:19         ` Arnaldo Carvalho de Melo
2017-10-09 20:33 ` [PATCH v5 12/16] perf report: cache failed lookups of inlined frames Milian Wolff
2017-10-09 20:33 ` [PATCH v5 13/16] perf report: cache srclines for callchain nodes Milian Wolff
2017-10-09 20:33 ` [PATCH v5 14/16] perf report: use srcline from callchain for hist entries Milian Wolff
2017-10-09 20:33 ` [PATCH v5 15/16] perf util: enable handling of inlined frames by default Milian Wolff
2017-10-09 20:33 ` [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry Milian Wolff
2017-10-10  4:49   ` Namhyung Kim
2017-10-12 18:22     ` Milian Wolff
2017-10-12 18:52       ` Jiri Olsa
2017-10-13 11:03         ` Jiri Olsa
2017-10-13  1:19       ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-9628b56dc1240ce0faa3bd9b7a3390fa4451c59f@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=milian.wolff@kdab.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox