Re: [PATCH] perf tools: Check '/tmp/perf-' symbol file ownership

Pekka Enberg
2011-08-09T19:55:41Z

On Tue, Aug 9, 2011 at 10:54 PM, Pekka Enberg <penberg@kernel.org> wrote:
> The external symbol files are generated by JIT compilers, for example, but we
> need to make sure they're ours before injecting them to 'perf report'.
>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Pekka Enberg <penberg@kernel.org>

Doh - I forgot to CC Ingo who asked for this in the first place...

> ---
>  tools/perf/util/symbol.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index eec1963..a8b5371 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -1504,6 +1504,17 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter)
>        dso->adjust_symbols = 0;
>
>        if (strncmp(dso->name, "/tmp/perf-", 10) == 0) {
> +               struct stat st;
> +
> +               if (stat(dso->name, &st) < 0)
> +                       return -1;
> +
> +               if (st.st_uid && (st.st_uid != geteuid())) {
> +                       pr_warning("File %s not owned by current user or root, "
> +                               "ignoring it.\n", dso->name);
> +                       return -1;
> +               }
> +
>                ret = dso__load_perf_map(dso, map, filter);
>                dso->symtab_type = ret > 0 ? SYMTAB__JAVA_JIT :
>                                              SYMTAB__NOT_FOUND;
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>