From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4284C04AAF for ; Sat, 18 May 2019 08:53:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B793D206BF for ; Sat, 18 May 2019 08:53:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="sKBCEypm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729455AbfERIxa (ORCPT ); Sat, 18 May 2019 04:53:30 -0400 Received: from terminus.zytor.com ([198.137.202.136]:40785 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727156AbfERIx3 (ORCPT ); Sat, 18 May 2019 04:53:29 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x4I8rEd61732516 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 18 May 2019 01:53:14 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 terminus.zytor.com x4I8rEd61732516 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2019041745; t=1558169595; bh=frca8zZd1TVZkjuhyHv2EYJB355SEFXdTb1IFOkc+5g=; h=Date:From:Cc:Reply-To:To:Subject:From; b=sKBCEypmENa9aleZcyRbvIjVpucWIpDK70aevgQXuO25atUtxRj1Rutseu+sZMHwH HQjpXQ+UJPE5cO2Bh1voyxkR5eVHlDf6yv+nCDYOOUL4nnefWhxMgM/8r7c0HYS+XV kOSLZ9mIdnRbHVOcWiq6QZNSjid2WMq/5eRAMf6G8HV5ME9OVn07bvxmbs/lVRAPfl FXcQE/ZwuzTKPPJ1YYpY9uXljbWZkRz+GzlHQXNcDkF2GD/mcKGBSLYQtVetXjUy7h FY0DbNUgwE0iEzFayZhVagy5TIKlGp9phWXWB48GZyIoRQn3OLkrClCWZRO1a53mcH PUivaWTmFhDnA== Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x4I8rDrE1732512; Sat, 18 May 2019 01:53:13 -0700 Date: Sat, 18 May 2019 01:53:13 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: eranian@google.com, adrian.hunter@intel.com, jolsa@kernel.org, kan.liang@linux.intel.com, alexander.shishkin@linux.intel.com, tglx@linutronix.de, ak@linux.intel.com, hpa@zytor.com, peterz@infradead.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, acme@redhat.com, mingo@kernel.org Reply-To: peterz@infradead.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, ak@linux.intel.com, tglx@linutronix.de, hpa@zytor.com, mingo@kernel.org, acme@redhat.com, adrian.hunter@intel.com, jolsa@kernel.org, eranian@google.com, kan.liang@linux.intel.com, alexander.shishkin@linux.intel.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf parse-regs: Improve error output when faced with unknown register name Git-Commit-ID: 4c1cf20334ae6e390e1ea787ef76c40a161370d1 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 4c1cf20334ae6e390e1ea787ef76c40a161370d1 Gitweb: https://git.kernel.org/tip/4c1cf20334ae6e390e1ea787ef76c40a161370d1 Author: Arnaldo Carvalho de Melo AuthorDate: Mon, 13 May 2019 14:28:32 -0400 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 15 May 2019 16:36:47 -0300 perf parse-regs: Improve error output when faced with unknown register name Add quotes around the register name and suggest using 'perf record -I?' to get the list of available registers. Before: # perf record -Idi,xmm20,xmm1 Warning: unknown register xmm20, check man page Usage: perf record [] [] or: perf record [] -- [] -I, --intr-regs[=] sample selected machine registers on interrupt, use -I ? to list register names # # perf record -Idi,xmm20,xmm1 Warning: unknown register "xmm20", check man page or run "perf record -I?" Usage: perf record [] [] or: perf record [] -- [] -I, --intr-regs[=] sample selected machine registers on interrupt, use -I ? to list register names # Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Jiri Olsa Cc: Kan Liang Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: https://lkml.kernel.org/n/tip-9a9hyuum8c0oggg86xd3sxc5@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/parse-regs-options.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/util/parse-regs-options.c b/tools/perf/util/parse-regs-options.c index e6599e290f46..9cb187a20fe2 100644 --- a/tools/perf/util/parse-regs-options.c +++ b/tools/perf/util/parse-regs-options.c @@ -48,8 +48,7 @@ parse_regs(const struct option *opt, const char *str, int unset) break; } if (!r->name) { - ui__warning("unknown register %s," - " check man page\n", s); + ui__warning("Unknown register \"%s\", check man page or run \"perf record -I?\"\n", s); goto error; }