[PATCH 4/4] [perf] fixed faulty check

[PATCH 4/4] [perf] fixed faulty check

[Stoyan Gaydarov]

This patche fixes a spelling error that has resulted from copy and pasting. The location of the error was found using a semantic patch but the semantic patch was not trying to find these errors. After looking things over it seemed logical that this change was needed. Please review it and then include the patch if it is in fact the correct change.

Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
---
 tools/perf/util/symbol.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 2810605..b4fe057 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -565,7 +565,7 @@ static int dso__load_sym(struct dso *self, int fd, const char *name,
 		goto out_elf_end;
 
 	secstrs = elf_getdata(sec_strndx, NULL);
-	if (symstrs == NULL)
+	if (secstrs == NULL)
 		goto out_elf_end;
 
 	nr_syms = shdr.sh_size / shdr.sh_entsize;
-- 
1.6.3.3

Re: [PATCH 4/4] [perf] fixed faulty check

[Peter Zijlstra]

On Thu, 2009-07-30 at 05:25 -0500, Stoyan Gaydarov wrote:
> This patche fixes a spelling error that has resulted from copy and
> pasting. The location of the error was found using a semantic patch
> but the semantic patch was not trying to find these errors. After
> looking things over it seemed logical that this change was needed.
> Please review it and then include the patch if it is in fact the
> correct change.

Looks sane to me. I'll pick it up. Thanks!

> Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
> ---
>  tools/perf/util/symbol.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 2810605..b4fe057 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -565,7 +565,7 @@ static int dso__load_sym(struct dso *self, int fd, const char *name,
>  		goto out_elf_end;
>  
>  	secstrs = elf_getdata(sec_strndx, NULL);
> -	if (symstrs == NULL)
> +	if (secstrs == NULL)
>  		goto out_elf_end;
>  
>  	nr_syms = shdr.sh_size / shdr.sh_entsize;

[tip:perfcounters/core] perf tools: Fix faulty check

[tip-bot for Stoyan Gaydarov]

Commit-ID:  9b30a26bf3d2c56dcb1c3afaca28b73fcd6ed405
Gitweb:     http://git.kernel.org/tip/9b30a26bf3d2c56dcb1c3afaca28b73fcd6ed405
Author:     Stoyan Gaydarov <sgayda2@uiuc.edu>
AuthorDate: Thu, 30 Jul 2009 05:25:29 -0500
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 2 Aug 2009 13:47:59 +0200

perf tools: Fix faulty check

This patch fixes a spelling error that has resulted from copy
and pasting. The location of the error was found using a
semantic patch but the semantic patch was not trying to find
these errors. After looking things over it seemed logical that
this change was needed. Please review it and then include the
patch if it is in fact the correct change.

Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1248949529-20891-1-git-send-email-sgayda2@uiuc.edu>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 tools/perf/util/symbol.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 2810605..b4fe057 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -565,7 +565,7 @@ static int dso__load_sym(struct dso *self, int fd, const char *name,
 		goto out_elf_end;
 
 	secstrs = elf_getdata(sec_strndx, NULL);
-	if (symstrs == NULL)
+	if (secstrs == NULL)
 		goto out_elf_end;
 
 	nr_syms = shdr.sh_size / shdr.sh_entsize;