public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	tzanussi@gmail.com, fweisbec@gmail.com, rostedt@goodmis.org,
	tglx@linutronix.de, mingo@elte.hu
Subject: [tip:tracing/filters] tracing/events: make the filter files writable
Date: Mon, 23 Mar 2009 08:30:43 GMT	[thread overview]
Message-ID: <tip-9bd7d099ab3f10dd666da399c064999bae427cd9@git.kernel.org> (raw)
In-Reply-To: <1237759847-21025-1-git-send-email-fweisbec@gmail.com>

Commit-ID:  9bd7d099ab3f10dd666da399c064999bae427cd9
Gitweb:     http://git.kernel.org/tip/9bd7d099ab3f10dd666da399c064999bae427cd9
Author:     Frederic Weisbecker <fweisbec@gmail.com>
AuthorDate: Sun, 22 Mar 2009 23:10:43 +0100
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 23 Mar 2009 09:22:14 +0100

tracing/events: make the filter files writable

We need the filter files to be writable, the current
filter file permissions are only set readable.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <1237759847-21025-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 kernel/trace/trace_events.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 594d78a..19f61dd 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -706,7 +706,7 @@ event_subsystem_dir(const char *name, struct dentry *d_events)
 
 	system->preds = NULL;
 
-	entry = debugfs_create_file("filter", 0444, system->entry, system,
+	entry = debugfs_create_file("filter", 0644, system->entry, system,
 				    &ftrace_subsystem_filter_fops);
 	if (!entry)
 		pr_warning("Could not create debugfs "
@@ -769,7 +769,7 @@ event_create_dir(struct ftrace_event_call *call, struct dentry *d_events)
 		}
 	}
 
-	entry = debugfs_create_file("filter", 0444, call->dir, call,
+	entry = debugfs_create_file("filter", 0644, call->dir, call,
 				    &ftrace_event_filter_fops);
 	if (!entry)
 		pr_warning("Could not create debugfs "

      parent reply	other threads:[~2009-03-23  8:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-22 22:10 [PATCH 1/5] tracing/events: make the filter files writable Frederic Weisbecker
2009-03-22 22:10 ` [PATCH 2/5] debugfs: function to know if debugfs is initialized Frederic Weisbecker
2009-03-23  8:18   ` Ingo Molnar
2009-03-23 14:41     ` Greg KH
2009-03-23 16:08       ` Ingo Molnar
2009-03-23 15:57   ` [tip:tracing/ftrace] " Frederic Weisbecker
2009-03-22 22:10 ` [PATCH 3/5] tracing/ftrace: check if debugfs is registered before creating files Frederic Weisbecker
2009-03-23  8:26   ` Ingo Molnar
2009-03-23 15:57   ` [tip:tracing/ftrace] " Frederic Weisbecker
2009-03-23 19:18   ` [PATCH 3/5] " Steven Rostedt
2009-03-23 19:22     ` Ingo Molnar
2009-03-23 19:47     ` Frederic Weisbecker
2009-03-22 22:10 ` [PATCH 4/5] tracing/events: don't use wake up for events Frederic Weisbecker
2009-03-23  8:30   ` [tip:tracing/filters] " Frederic Weisbecker
2009-03-23 19:21     ` Steven Rostedt
2009-03-23 19:33       ` Frederic Weisbecker
2009-03-22 22:10 ` [PATCH 5/5] tracing/ftrace: make nop using polling wait for events on pipe Frederic Weisbecker
2009-03-23  8:31   ` [tip:tracing/filters] tracing/ftrace: make nop-tracer use " Frederic Weisbecker
2009-03-22 22:12 ` [PATCH 1/5] tracing/events: make the filter files writable Frederic Weisbecker
2009-03-23  8:25 ` Ingo Molnar
2009-03-23  8:31   ` Frederic Weisbecker
2009-03-23  8:30 ` Frederic Weisbecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-9bd7d099ab3f10dd666da399c064999bae427cd9@git.kernel.org \
    --to=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox