From: tip-bot for Juergen Gross <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, hpa@zytor.com, mingo@kernel.org,
linux-kernel@vger.kernel.org, akataria@vmware.com,
jongman.heo@samsung.com, jgross@suse.com
Subject: [tip:x86/urgent] x86: Don' t rely on VMWare emulating PAT MSR correctly
Date: Tue, 20 Jan 2015 05:36:36 -0800 [thread overview]
Message-ID: <tip-9d34cfdf47963905d792ae9c000efa522739abe4@git.kernel.org> (raw)
In-Reply-To: <1421039745-14335-1-git-send-email-jgross@suse.com>
Commit-ID: 9d34cfdf47963905d792ae9c000efa522739abe4
Gitweb: http://git.kernel.org/tip/9d34cfdf47963905d792ae9c000efa522739abe4
Author: Juergen Gross <jgross@suse.com>
AuthorDate: Mon, 12 Jan 2015 06:15:45 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 20 Jan 2015 14:33:45 +0100
x86: Don't rely on VMWare emulating PAT MSR correctly
VMWare seems not to emulate the PAT MSR correctly: reaeding
MSR_IA32_CR_PAT returns 0 even after writing another value to it.
Commit bd809af16e3ab triggers this VMWare bug when the kernel is
booted as a VMWare guest.
Detect this bug and don't use the read value if it is 0.
Fixes: bd809af16e3ab "x86: Enable PAT to use cache mode translation tables"
Reported-and-tested-by: Jongman Heo <jongman.heo@samsung.com>
Acked-by: Alok N Kataria <akataria@vmware.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Link: http://lkml.kernel.org/r/1421039745-14335-1-git-send-email-jgross@suse.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/mm/pat.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index edf299c..7ac6869 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -234,8 +234,13 @@ void pat_init(void)
PAT(4, WB) | PAT(5, WC) | PAT(6, UC_MINUS) | PAT(7, UC);
/* Boot CPU check */
- if (!boot_pat_state)
+ if (!boot_pat_state) {
rdmsrl(MSR_IA32_CR_PAT, boot_pat_state);
+ if (!boot_pat_state) {
+ pat_disable("PAT read returns always zero, disabled.");
+ return;
+ }
+ }
wrmsrl(MSR_IA32_CR_PAT, pat);
prev parent reply other threads:[~2015-01-20 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 5:15 [Patch RESEND] x86: don't rely on VMWare emulating PAT MSR correctly Juergen Gross
2015-01-19 5:05 ` Juergen Gross
2015-01-19 5:13 ` Alok Kataria
2015-01-20 13:36 ` tip-bot for Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-9d34cfdf47963905d792ae9c000efa522739abe4@git.kernel.org \
--to=tipbot@zytor.com \
--cc=akataria@vmware.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jongman.heo@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox