* [PATCH] perf_tools/sched: cleanup, remove unused variables in map_switch_event().
@ 2014-05-16 5:37 Dongsheng Yang
2014-05-21 5:54 ` [tip:perf/core] perf sched: Cleanup, " tip-bot for Dongsheng Yang
0 siblings, 1 reply; 2+ messages in thread
From: Dongsheng Yang @ 2014-05-16 5:37 UTC (permalink / raw)
To: acme, jolsa; +Cc: linux-kernel, Dongsheng Yang
In map_switch_event(), we don't care the previous process currently,
this patch remove the infomation we get but not used.
Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
---
tools/perf/builtin-sched.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 2579215..1eb2369 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1266,9 +1266,8 @@ static int process_sched_wakeup_event(struct perf_tool *tool,
static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
struct perf_sample *sample, struct machine *machine)
{
- const u32 prev_pid = perf_evsel__intval(evsel, sample, "prev_pid"),
- next_pid = perf_evsel__intval(evsel, sample, "next_pid");
- struct thread *sched_out __maybe_unused, *sched_in;
+ const u32 next_pid = perf_evsel__intval(evsel, sample, "next_pid");
+ struct thread *sched_in;
int new_shortname;
u64 timestamp0, timestamp = sample->time;
s64 delta;
@@ -1291,7 +1290,6 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
return -1;
}
- sched_out = machine__findnew_thread(machine, 0, prev_pid);
sched_in = machine__findnew_thread(machine, 0, next_pid);
sched->curr_thread[this_cpu] = sched_in;
--
1.8.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:perf/core] perf sched: Cleanup, remove unused variables in map_switch_event()
2014-05-16 5:37 [PATCH] perf_tools/sched: cleanup, remove unused variables in map_switch_event() Dongsheng Yang
@ 2014-05-21 5:54 ` tip-bot for Dongsheng Yang
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Dongsheng Yang @ 2014-05-21 5:54 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, jolsa, tglx, yangds.fnst
Commit-ID: 9d372ca59bcb9339b4a34a9bf978a1fc15b68b03
Gitweb: http://git.kernel.org/tip/9d372ca59bcb9339b4a34a9bf978a1fc15b68b03
Author: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
AuthorDate: Fri, 16 May 2014 14:37:05 +0900
Committer: Jiri Olsa <jolsa@kernel.org>
CommitDate: Fri, 16 May 2014 09:17:50 +0200
perf sched: Cleanup, remove unused variables in map_switch_event()
In map_switch_event(), we don't care the previous process currently,
this patch remove the infomation we get but not used.
Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Link: http://lkml.kernel.org/r/1400218625-14613-1-git-send-email-yangds.fnst@cn.fujitsu.com
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/builtin-sched.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 0b4fe53..d717683 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1266,9 +1266,8 @@ static int process_sched_wakeup_event(struct perf_tool *tool,
static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
struct perf_sample *sample, struct machine *machine)
{
- const u32 prev_pid = perf_evsel__intval(evsel, sample, "prev_pid"),
- next_pid = perf_evsel__intval(evsel, sample, "next_pid");
- struct thread *sched_out __maybe_unused, *sched_in;
+ const u32 next_pid = perf_evsel__intval(evsel, sample, "next_pid");
+ struct thread *sched_in;
int new_shortname;
u64 timestamp0, timestamp = sample->time;
s64 delta;
@@ -1291,7 +1290,6 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
return -1;
}
- sched_out = machine__findnew_thread(machine, 0, prev_pid);
sched_in = machine__findnew_thread(machine, 0, next_pid);
sched->curr_thread[this_cpu] = sched_in;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-21 5:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-16 5:37 [PATCH] perf_tools/sched: cleanup, remove unused variables in map_switch_event() Dongsheng Yang
2014-05-21 5:54 ` [tip:perf/core] perf sched: Cleanup, " tip-bot for Dongsheng Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox