public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Frans Pop <elendil@planet.nl>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	a.p.zijlstra@chello.nl, elendil@planet.nl, tglx@linutronix.de,
	mingo@elte.hu
Subject: [tip:sched/urgent] sched: Correct printk whitespace in warning from cpu down task check
Date: Thu, 28 Jan 2010 07:12:46 GMT	[thread overview]
Message-ID: <tip-9d3cfc4c1d17c6d3bc1373e3b954c56b92607755@git.kernel.org> (raw)
In-Reply-To: <201001251456.34996.elendil@planet.nl>

Commit-ID:  9d3cfc4c1d17c6d3bc1373e3b954c56b92607755
Gitweb:     http://git.kernel.org/tip/9d3cfc4c1d17c6d3bc1373e3b954c56b92607755
Author:     Frans Pop <elendil@planet.nl>
AuthorDate: Mon, 25 Jan 2010 14:56:34 +0100
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 28 Jan 2010 06:59:55 +0100

sched: Correct printk whitespace in warning from cpu down task check

Due to an incorrect line break the output currently contains tabs.
Also remove trailing space.

The actual output that logcheck sent me looked like this:
 Task events/1 (pid = 10) is on cpu 1^I^I^I^I(state = 1, flags = 84208040)

After this patch it becomes:
 Task events/1 (pid = 10) is on cpu 1 (state = 1, flags = 84208040)

Signed-off-by: Frans Pop <elendilplanet.nl>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <201001251456.34996.elendil@planet.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/cpu.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index 08e54e7..677f253 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -154,10 +154,10 @@ static inline void check_for_tasks(int cpu)
 		if (task_cpu(p) == cpu && p->state == TASK_RUNNING &&
 		    (!cputime_eq(p->utime, cputime_zero) ||
 		     !cputime_eq(p->stime, cputime_zero)))
-			printk(KERN_WARNING "Task %s (pid = %d) is on cpu %d\
-				(state = %ld, flags = %x) \n",
-				 p->comm, task_pid_nr(p), cpu,
-				 p->state, p->flags);
+			printk(KERN_WARNING "Task %s (pid = %d) is on cpu %d "
+				"(state = %ld, flags = %x)\n",
+				p->comm, task_pid_nr(p), cpu,
+				p->state, p->flags);
 	}
 	write_unlock_irq(&tasklist_lock);
 }

      parent reply	other threads:[~2010-01-28  7:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-25  4:42 Warnings about tasks on CPU 1 during STR Frans Pop
2010-01-25 12:50 ` Peter Zijlstra
2010-01-25 13:52   ` Frans Pop
2010-01-25 13:56 ` [PATCH] sched: correct whitespace in warning from cpu down task check Frans Pop
2010-01-27 13:16   ` [tip:sched/urgent] sched: Correct printk " tip-bot for Frans Pop
2010-01-28  7:12   ` tip-bot for Frans Pop [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-9d3cfc4c1d17c6d3bc1373e3b954c56b92607755@git.kernel.org \
    --to=elendil@planet.nl \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox