linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] lib/cpumask: Make CPUMASK_OFFSTACK usable without debug dependency
@ 2013-11-11 14:08 Josh Boyer
  2013-11-13  3:51 ` [tip:core/urgent] smp/cpumask: Make CONFIG_CPUMASK_OFFSTACK= y " tip-bot for Josh Boyer
  0 siblings, 1 reply; 2+ messages in thread
From: Josh Boyer @ 2013-11-11 14:08 UTC (permalink / raw)
  To: Ingo Molnar, Thomas Gleixner, H. Peter Anvin
  Cc: x86, Andrew Morton, linux-kernel

When CPUMASK_OFFSTACK was added in 2008, it was dependent upon
DEBUG_PER_CPU_MAPS being enabled, or an architecture could select it.
The debug dependency adds additional overhead that isn't required for
operation of the feature, and we need CPUMASK_OFFSTACK to increase the
NR_CPUS value beyond 512 on x86.  We drop the current dependency and make
sure SMP is set.

Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---
 lib/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/Kconfig b/lib/Kconfig
index b3c8be0..50b47cd 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -342,7 +342,8 @@ config CHECK_SIGNATURE
 	bool
 
 config CPUMASK_OFFSTACK
-	bool "Force CPU masks off stack" if DEBUG_PER_CPU_MAPS
+	bool "Force CPU masks off stack"
+	depends on SMP
 	help
 	  Use dynamic allocation for cpumask_var_t, instead of putting
 	  them on the stack.  This is a bit more expensive, but avoids
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:core/urgent] smp/cpumask: Make CONFIG_CPUMASK_OFFSTACK= y usable without debug dependency
  2013-11-11 14:08 [PATCH] lib/cpumask: Make CPUMASK_OFFSTACK usable without debug dependency Josh Boyer
@ 2013-11-13  3:51 ` tip-bot for Josh Boyer
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Josh Boyer @ 2013-11-13  3:51 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, a.p.zijlstra, torvalds, rusty, jwboyer,
	jwboyer, akpm, tglx

Commit-ID:  9dd1220114e00d8ec5cdc20085bbe198b21e1985
Gitweb:     http://git.kernel.org/tip/9dd1220114e00d8ec5cdc20085bbe198b21e1985
Author:     Josh Boyer <jwboyer@redhat.com>
AuthorDate: Mon, 11 Nov 2013 09:08:15 -0500
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 13 Nov 2013 00:45:50 +0100

smp/cpumask: Make CONFIG_CPUMASK_OFFSTACK=y usable without debug dependency

When CONFIG_CPUMASK_OFFSTACK was added in 2008, it was dependent upon
CONFIG_DEBUG_PER_CPU_MAPS being enabled, or an architecture could
select it.

The debug dependency adds additional overhead that isn't required
for operation of the feature and which is undesirable for distro
kernels. CONFIG_CPUMASK_OFFSTACK=y is needed to increase the
CONFIG_NR_CPUS value beyond 512 on x86.

So drop the current dependency, its only real dependency is CONFIG_SMP=y.

Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20131111140815.GB20328@hansolo.jdub.homelinux.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 lib/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/Kconfig b/lib/Kconfig
index b3c8be0..50b47cd 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -342,7 +342,8 @@ config CHECK_SIGNATURE
 	bool
 
 config CPUMASK_OFFSTACK
-	bool "Force CPU masks off stack" if DEBUG_PER_CPU_MAPS
+	bool "Force CPU masks off stack"
+	depends on SMP
 	help
 	  Use dynamic allocation for cpumask_var_t, instead of putting
 	  them on the stack.  This is a bit more expensive, but avoids

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-11-13  3:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-11 14:08 [PATCH] lib/cpumask: Make CPUMASK_OFFSTACK usable without debug dependency Josh Boyer
2013-11-13  3:51 ` [tip:core/urgent] smp/cpumask: Make CONFIG_CPUMASK_OFFSTACK= y " tip-bot for Josh Boyer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).