From: tip-bot for Mike Galbraith <efault@gmx.de>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
efault@gmx.de, heukelum@fastmail.fm, tglx@linutronix.de,
gorcunov@gmail.com, mingo@elte.hu
Subject: [tip:x86/urgent] x86: Fix symbol annotation for arch/x86/lib/clear_page_64.S::clear_page_c
Date: Tue, 30 Jun 2009 21:45:38 GMT [thread overview]
Message-ID: <tip-9e314996e3dc5189b9b36dce67088e882e989897@git.kernel.org> (raw)
In-Reply-To: <1246366820.6538.1.camel@marge.simson.net>
Commit-ID: 9e314996e3dc5189b9b36dce67088e882e989897
Gitweb: http://git.kernel.org/tip/9e314996e3dc5189b9b36dce67088e882e989897
Author: Mike Galbraith <efault@gmx.de>
AuthorDate: Tue, 30 Jun 2009 15:00:20 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 30 Jun 2009 23:43:15 +0200
x86: Fix symbol annotation for arch/x86/lib/clear_page_64.S::clear_page_c
Noticed the zero-sized function symbol while looking at 'perf' profiles,
it causes the profiler to display those addresses in hexa.
Turns out that this was wrong/bogus for an eternity.
Signed-off-by: Mike Galbraith <efault@gmx.de>
Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>
Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>
LKML-Reference: <1246366820.6538.1.camel@marge.simson.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/lib/clear_page_64.S | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/lib/clear_page_64.S b/arch/x86/lib/clear_page_64.S
index 9a10a78..ebeafcc 100644
--- a/arch/x86/lib/clear_page_64.S
+++ b/arch/x86/lib/clear_page_64.S
@@ -5,15 +5,14 @@
* Zero a page.
* rdi page
*/
- ALIGN
-clear_page_c:
+ENTRY(clear_page_c)
CFI_STARTPROC
movl $4096/8,%ecx
xorl %eax,%eax
rep stosq
ret
CFI_ENDPROC
-ENDPROC(clear_page)
+ENDPROC(clear_page_c)
ENTRY(clear_page)
CFI_STARTPROC
prev parent reply other threads:[~2009-06-30 21:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 10:54 [patch] x86: fix arch/x86/lib/clear_page_64.S::clear_page_c annotation Mike Galbraith
2009-06-30 11:42 ` Alexander van Heukelum
2009-06-30 13:00 ` Mike Galbraith
2009-06-30 13:51 ` Cyrill Gorcunov
2009-06-30 21:45 ` tip-bot for Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-9e314996e3dc5189b9b36dce67088e882e989897@git.kernel.org \
--to=efault@gmx.de \
--cc=gorcunov@gmail.com \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox