From: tip-bot for Namhyung Kim <namhyung.kim@lge.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org,
eranian@google.com, paulus@samba.org, hpa@zytor.com,
mingo@kernel.org, a.p.zijlstra@chello.nl, namhyung.kim@lge.com,
namhyung@kernel.org, jolsa@redhat.com, fweisbec@gmail.com,
dsahern@gmail.com, tglx@linutronix.de, asharma@fb.com
Subject: [tip:perf/core] perf hists: Add missing period_* fields when collapsing a hist entry
Date: Fri, 28 Sep 2012 09:37:20 -0700 [thread overview]
Message-ID: <tip-9ec60972a38011ad8a5676f4cd5e51ac508c36b6@git.kernel.org> (raw)
In-Reply-To: <1348645663-25303-2-git-send-email-namhyung@kernel.org>
Commit-ID: 9ec60972a38011ad8a5676f4cd5e51ac508c36b6
Gitweb: http://git.kernel.org/tip/9ec60972a38011ad8a5676f4cd5e51ac508c36b6
Author: Namhyung Kim <namhyung.kim@lge.com>
AuthorDate: Wed, 26 Sep 2012 16:47:28 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 26 Sep 2012 20:44:11 -0300
perf hists: Add missing period_* fields when collapsing a hist entry
So that the perf report won't lost the cpu utilization information.
For example, if there're two process that have same name.
$ perf report --stdio --showcpuutilization -s pid
[SNIP]
# Overhead sys us Command: Pid
# ........ ........ ........ .............
#
55.12% 0.01% 55.10% noploop:28781
44.88% 0.06% 44.83% noploop:28782
Before:
$ perf report --stdio --showcpuutilization -s comm
[SNIP]
# Overhead sys us
# ........ ........ ........
#
100.00% 0.06% 44.83%
After:
$ perf report --stdio --showcpuutilization -s comm
[SNIP]
# Overhead sys us
# ........ ........ ........
#
100.00% 0.07% 99.93%
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Arun Sharma <asharma@fb.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1348645663-25303-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/hist.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 6ec5398..236bc9d 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -410,8 +410,13 @@ static bool hists__collapse_insert_entry(struct hists *hists __maybe_unused,
cmp = hist_entry__collapse(iter, he);
if (!cmp) {
- iter->period += he->period;
- iter->nr_events += he->nr_events;
+ iter->period += he->period;
+ iter->period_sys += he->period_sys;
+ iter->period_us += he->period_us;
+ iter->period_guest_sys += he->period_guest_sys;
+ iter->period_guest_us += he->period_guest_us;
+ iter->nr_events += he->nr_events;
+
if (symbol_conf.use_callchain) {
callchain_cursor_reset(&callchain_cursor);
callchain_merge(&callchain_cursor,
next prev parent reply other threads:[~2012-09-28 16:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 7:47 [PATCH 00/16] perf report: Add suppport for event group view (v2) Namhyung Kim
2012-09-26 7:47 ` [PATCH 01/16] perf hists: Add missing period_* fields when collapsing a hist entry Namhyung Kim
2012-09-28 16:37 ` tip-bot for Namhyung Kim [this message]
2012-09-26 7:47 ` [PATCH 02/16] perf hists: Introduce struct he_stat Namhyung Kim
2012-09-26 7:47 ` [PATCH 03/16] perf hists: Move he->stat.nr_events initialization to a template Namhyung Kim
2012-09-26 7:47 ` [PATCH 04/16] perf hists: Add more helpers for hist entry stat Namhyung Kim
2012-09-26 7:47 ` [PATCH 05/16] perf tools: Keep group information Namhyung Kim
2012-09-27 17:03 ` Jiri Olsa
2012-09-28 4:49 ` Namhyung Kim
2012-09-26 7:47 ` [PATCH 06/16] perf evlist: Add perf_evlist__recalc_nr_groups Namhyung Kim
2012-09-26 7:47 ` [PATCH 07/16] perf header: Add HEADER_GROUP_DESC feature Namhyung Kim
2012-09-26 7:47 ` [PATCH 08/16] perf hists: Collapse group hist_entries to a leader Namhyung Kim
2012-09-26 7:47 ` [PATCH 09/16] perf hists: Maintain total periods of group members in the leader Namhyung Kim
2012-09-26 7:47 ` [PATCH 10/16] perf report: Make another loop for output resorting Namhyung Kim
2012-09-26 7:47 ` [PATCH 11/16] perf ui/hist: Add support for event group view Namhyung Kim
2012-09-26 7:47 ` [PATCH 12/16] perf ui/browser: " Namhyung Kim
2012-09-26 7:47 ` [PATCH 13/16] perf ui/gtk: " Namhyung Kim
2012-09-26 7:47 ` [PATCH 14/16] perf report: Bypass non-leader events when event group is enabled Namhyung Kim
2012-09-26 7:47 ` [PATCH 15/16] perf report: Show group description " Namhyung Kim
2012-09-26 7:47 ` [PATCH 16/16] perf report: Add --group option Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-9ec60972a38011ad8a5676f4cd5e51ac508c36b6@git.kernel.org \
--to=namhyung.kim@lge.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=asharma@fb.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).