From: tip-bot for Jia-Ju Bai <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@kernel.org, torvalds@linux-foundation.org,
ard.biesheuvel@linaro.org, peterz@infradead.org,
baijiaju1990@gmail.com, hpa@zytor.com, matt@codeblueprint.co.uk
Subject: [tip:efi/core] x86/efi: Replace GFP_ATOMIC with GFP_KERNEL in efi_query_variable_store()
Date: Fri, 9 Mar 2018 01:13:19 -0800 [thread overview]
Message-ID: <tip-9f66d8d73e654c5f867daa6aa186300ecaf49d3a@git.kernel.org> (raw)
In-Reply-To: <20180308080020.22828-7-ard.biesheuvel@linaro.org>
Commit-ID: 9f66d8d73e654c5f867daa6aa186300ecaf49d3a
Gitweb: https://git.kernel.org/tip/9f66d8d73e654c5f867daa6aa186300ecaf49d3a
Author: Jia-Ju Bai <baijiaju1990@gmail.com>
AuthorDate: Thu, 8 Mar 2018 08:00:14 +0000
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 9 Mar 2018 08:58:22 +0100
x86/efi: Replace GFP_ATOMIC with GFP_KERNEL in efi_query_variable_store()
efi_query_variable_store() does an atomic kzalloc() unnecessarily,
because we can never get this far when called in an atomic context,
namely when nonblocking == 1.
Replace it with GFP_KERNEL.
This was found by the DCNS static analysis tool written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20180308080020.22828-7-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/platform/efi/quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/quirks.c
index 5b513ccffde4..1ef11c26f79b 100644
--- a/arch/x86/platform/efi/quirks.c
+++ b/arch/x86/platform/efi/quirks.c
@@ -177,7 +177,7 @@ efi_status_t efi_query_variable_store(u32 attributes, unsigned long size,
* that by attempting to use more space than is available.
*/
unsigned long dummy_size = remaining_size + 1024;
- void *dummy = kzalloc(dummy_size, GFP_ATOMIC);
+ void *dummy = kzalloc(dummy_size, GFP_KERNEL);
if (!dummy)
return EFI_OUT_OF_RESOURCES;
next prev parent reply other threads:[~2018-03-09 9:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 8:00 [GIT PULL 00/12] first batch of EFI changes for v4.17 Ard Biesheuvel
2018-03-08 8:00 ` [PATCH 01/12] efi/arm*: Only register page tables when they exist Ard Biesheuvel
2018-03-09 9:11 ` [tip:efi/core] " tip-bot for Mark Rutland
2018-03-08 8:00 ` [PATCH 02/12] efi/apple-properties: Device core takes care of empty properties Ard Biesheuvel
2018-03-09 9:11 ` [tip:efi/core] efi/apple-properties: Remove redundant attribute initialization from unmarshal_key_value_pairs() tip-bot for Andy Shevchenko
2018-03-08 8:00 ` [PATCH 03/12] efi/arm*: Stop printing addresses of virtual mappings Ard Biesheuvel
2018-03-09 9:12 ` [tip:efi/core] " tip-bot for Ard Biesheuvel
2018-03-08 8:00 ` [PATCH 04/12] efi/x86: Fix trailing semicolons Ard Biesheuvel
2018-03-08 8:00 ` [PATCH 05/12] efi: arm64: Check whether x18 is preserved by runtime services calls Ard Biesheuvel
2018-03-09 9:12 ` [tip:efi/core] efi/arm64: " tip-bot for Ard Biesheuvel
2018-03-08 8:00 ` [PATCH 06/12] x86: efi: Replace GFP_ATOMIC with GFP_KERNEL in efi_query_variable_store Ard Biesheuvel
2018-03-09 7:54 ` Ingo Molnar
2018-03-09 9:13 ` tip-bot for Jia-Ju Bai [this message]
2018-03-08 8:00 ` [PATCH 07/12] efi: Use efi_mm in x86 as well as ARM Ard Biesheuvel
2018-03-09 7:40 ` Ingo Molnar
2018-03-09 8:37 ` Prakhya, Sai Praneeth
2018-03-09 9:56 ` Ard Biesheuvel
2018-03-08 8:00 ` [PATCH 08/12] x86/efi: Replace efi_pgd with efi_mm.pgd Ard Biesheuvel
2018-03-08 8:00 ` [PATCH 09/12] x86/efi: Use efi_switch_mm() rather than manually twiddling with %cr3 Ard Biesheuvel
2018-03-08 8:00 ` [PATCH 10/12] efi: reorder pr_notice() with add_device_randomness() call Ard Biesheuvel
2018-03-09 9:13 ` [tip:efi/core] efi: Reorder " tip-bot for Ard Biesheuvel
2018-03-08 8:00 ` [PATCH 11/12] efi/apple-properties: Use memremap() instead of ioremap() Ard Biesheuvel
2018-03-09 9:14 ` [tip:efi/core] " tip-bot for Andy Shevchenko
2018-03-08 8:00 ` [PATCH 12/12] efi: make const array 'apple' static Ard Biesheuvel
2018-03-08 11:05 ` Joe Perches
2018-03-09 7:43 ` Ard Biesheuvel
2018-03-09 7:44 ` Ard Biesheuvel
2018-03-09 9:37 ` Joe Perches
2018-03-09 7:47 ` Ingo Molnar
2018-03-09 7:52 ` Ard Biesheuvel
2018-03-09 8:04 ` Ingo Molnar
2018-03-09 8:07 ` Ard Biesheuvel
2018-03-09 8:19 ` Ard Biesheuvel
2018-03-09 8:31 ` Ingo Molnar
2018-03-09 8:29 ` Lukas Wunner
2018-03-09 8:33 ` Ard Biesheuvel
2018-03-09 9:16 ` [tip:efi/core] efi: Make " tip-bot for Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-9f66d8d73e654c5f867daa6aa186300ecaf49d3a@git.kernel.org \
--to=tipbot@zytor.com \
--cc=ard.biesheuvel@linaro.org \
--cc=baijiaju1990@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).