public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Julia Lawall <julia@diku.dk>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, julia@diku.dk, hpa@zytor.com,
	mingo@redhat.com, vegardno@ifi.uio.no, penberg@cs.helsinki.fi,
	tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/mm] x86, kmemcheck: Remove double test
Date: Mon, 30 Aug 2010 08:36:26 GMT	[thread overview]
Message-ID: <tip-9fbaf49c7f717740002d49eee1bbd03d89d8766a@git.kernel.org> (raw)
In-Reply-To: <1283010066-20935-5-git-send-email-julia@diku.dk>

Commit-ID:  9fbaf49c7f717740002d49eee1bbd03d89d8766a
Gitweb:     http://git.kernel.org/tip/9fbaf49c7f717740002d49eee1bbd03d89d8766a
Author:     Julia Lawall <julia@diku.dk>
AuthorDate: Sat, 28 Aug 2010 17:41:03 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 30 Aug 2010 09:19:28 +0200

x86, kmemcheck: Remove double test

The opcodes 0x2e and 0x3e are tested for in the first Group 2
line as well.

The sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression E;
@@

(
* E
  || ... || E
|
* E
  && ... && E
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Vegard Nossum <vegardno@ifi.uio.no>
LKML-Reference: <1283010066-20935-5-git-send-email-julia@diku.dk>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/mm/kmemcheck/opcode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/kmemcheck/opcode.c b/arch/x86/mm/kmemcheck/opcode.c
index 63c19e2..324aa3f 100644
--- a/arch/x86/mm/kmemcheck/opcode.c
+++ b/arch/x86/mm/kmemcheck/opcode.c
@@ -9,7 +9,7 @@ static bool opcode_is_prefix(uint8_t b)
 		b == 0xf0 || b == 0xf2 || b == 0xf3
 		/* Group 2 */
 		|| b == 0x2e || b == 0x36 || b == 0x3e || b == 0x26
-		|| b == 0x64 || b == 0x65 || b == 0x2e || b == 0x3e
+		|| b == 0x64 || b == 0x65
 		/* Group 3 */
 		|| b == 0x66
 		/* Group 4 */

  parent reply	other threads:[~2010-08-30  8:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-28 15:40 [PATCH 0/7] Remove double test Julia Lawall
2010-08-28 15:41 ` [PATCH 1/7] drivers/staging: " Julia Lawall
2010-08-28 15:41 ` [PATCH 2/7] drivers/usb/gadget: " Julia Lawall
2010-08-28 16:10   ` David Brownell
2010-08-28 16:53     ` Julia Lawall
2010-08-28 17:11       ` Stefan Richter
2010-08-28 17:17         ` Julia Lawall
2010-08-28 18:11           ` David Brownell
2010-08-28 18:19         ` David Brownell
2010-08-28 16:37   ` Dan Carpenter
2010-08-28 16:48     ` [PATCH 2/7] drivers/usb/gadget/amd5536udc.c: " Julia Lawall
2010-08-28 18:24       ` David Brownell
2010-09-01 10:03         ` Thomas Dahlmann
2010-08-28 16:49     ` [PATCH 2/7] drivers/usb/gadget: " Julia Lawall
2010-08-28 15:41 ` [PATCH 3/7] drivers/net/atl1c: " Julia Lawall
2010-08-28 16:50   ` Dan Carpenter
2010-08-28 20:10     ` Luis R. Rodriguez
2010-08-28 15:41 ` [PATCH 4/7] arch/x86/mm/kmemcheck: " Julia Lawall
2010-08-29 10:26   ` Pekka Enberg
2010-08-30  8:36   ` tip-bot for Julia Lawall [this message]
2010-09-02 19:08     ` [tip:x86/mm] x86, kmemcheck: " Vegard Nossum
2010-09-03  6:21       ` Ingo Molnar
2010-08-28 15:41 ` [PATCH 5/7] drivers/regulator: " Julia Lawall
2010-08-29 13:06   ` Mark Brown
2010-08-28 15:41 ` [PATCH 6/7] drivers/media/dvb/siano: " Julia Lawall
2010-08-28 15:41 ` [PATCH 7/7] net/wireless: " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-9fbaf49c7f717740002d49eee1bbd03d89d8766a@git.kernel.org \
    --to=julia@diku.dk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=tglx@linutronix.de \
    --cc=vegardno@ifi.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox