public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Boris Ostrovsky <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: boris.ostrovsky@oracle.com, hpa@zytor.com, mingo@kernel.org,
	linux-kernel@vger.kernel.org, tglx@linutronix.de, bp@suse.de
Subject: [tip:x86/microcode] x86, microcode: Don' t initialize microcode code on paravirt
Date: Mon, 8 Dec 2014 01:43:11 -0800	[thread overview]
Message-ID: <tip-a18a0f6850d4b286a5ebf02cd5b22fe496b86349@git.kernel.org> (raw)
In-Reply-To: <1417469264-31470-1-git-send-email-boris.ostrovsky@oracle.com>

Commit-ID:  a18a0f6850d4b286a5ebf02cd5b22fe496b86349
Gitweb:     http://git.kernel.org/tip/a18a0f6850d4b286a5ebf02cd5b22fe496b86349
Author:     Boris Ostrovsky <boris.ostrovsky@oracle.com>
AuthorDate: Mon, 1 Dec 2014 16:27:44 -0500
Committer:  Borislav Petkov <bp@suse.de>
CommitDate: Sat, 6 Dec 2014 12:59:03 +0100

x86, microcode: Don't initialize microcode code on paravirt

Paravirtual guests are not expected to load microcode into processors
and therefore it is not necessary to initialize microcode loading
logic.

In fact, under certain circumstances initializing this logic may cause
the guest to crash. Specifically, 32-bit kernels use __pa_nodebug()
macro which does not work in Xen (the code path that leads to this macro
happens during resume when we call mc_bp_resume()->load_ucode_ap()
->check_loader_disabled_ap())

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: http://lkml.kernel.org/r/1417469264-31470-1-git-send-email-boris.ostrovsky@oracle.com
Signed-off-by: Borislav Petkov <bp@suse.de>
---
 arch/x86/kernel/cpu/microcode/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index 2ce9051..ebd232d 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -557,7 +557,7 @@ static int __init microcode_init(void)
 	struct cpuinfo_x86 *c = &cpu_data(0);
 	int error;
 
-	if (dis_ucode_ldr)
+	if (paravirt_enabled() || dis_ucode_ldr)
 		return 0;
 
 	if (c->x86_vendor == X86_VENDOR_INTEL)

      parent reply	other threads:[~2014-12-08  9:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 21:27 [PATCH] x86, microcode: Don't initialize microcode code on paravirt Boris Ostrovsky
2014-12-01 21:57 ` Konrad Rzeszutek Wilk
2014-12-01 22:12   ` Paolo Bonzini
2014-12-01 22:31     ` Borislav Petkov
2014-12-01 22:00 ` Borislav Petkov
2014-12-01 22:31   ` Boris Ostrovsky
2014-12-01 22:37     ` Borislav Petkov
2014-12-02 14:36       ` Boris Ostrovsky
2014-12-02 14:58         ` Borislav Petkov
2014-12-02  1:28 ` Greg KH
2014-12-08  9:43 ` tip-bot for Boris Ostrovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-a18a0f6850d4b286a5ebf02cd5b22fe496b86349@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox